jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-04-04 08:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Streamline assertThat calls using appropriate matchers

Browse Source
This commit is contained in:
Liam Newman
2021-04-20 12:16:55 -07:00
parent d13e490be2
commit b550910f4c
27 changed files with 195 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/java/org/kohsuke/github/LifecycleTest.java
View File

@@ -1,7 +1,6 @@
package org.kohsuke.github;
import org.apache.commons.lang3.SystemUtils;
import org.hamcrest.Matchers;
import org.junit.Assume;
import org.junit.Test;
@@ -11,10 +10,7 @@ import java.io.IOException;
import java.io.PrintWriter;
import java.util.List;
import static org.hamcrest.CoreMatchers.*;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.notNullValue;
import static org.hamcrest.core.Is.is;
import static org.hamcrest.Matchers.*;
public class LifecycleTest extends AbstractGitHubWireMockTest {
@Test
@@ -25,7 +21,7 @@ public class LifecycleTest extends AbstractGitHubWireMockTest {
// GHOrganization org = gitHub.getOrganization(GITHUB_API_TEST_ORG);
GHRepository repository = getTempRepository();
assertThat(repository.getReleases().isEmpty(), Matchers.is(true));
assertThat(repository.getReleases(), is(empty()));
GHMilestone milestone = repository.createMilestone("Initial Release", "first one");
GHIssue issue = repository.createIssue("Test Issue")
@@ -53,14 +49,14 @@ public class LifecycleTest extends AbstractGitHubWireMockTest {
private void deleteAsset(GHRelease release, GHAsset asset) throws IOException {
asset.delete();
assertThat(release.getAssets().size(), equalTo(0));
assertThat(release.getAssets(), is(empty()));
}
private GHAsset uploadAsset(GHRelease release) throws IOException {
GHAsset asset = release.uploadAsset(new File("LICENSE.txt"), "application/text");
assertThat(asset, notNullValue());
List<GHAsset> cachedAssets = release.assets();
assertThat(cachedAssets.size(), equalTo(0));
assertThat(cachedAssets, is(empty()));
List<GHAsset> assets = release.getAssets();
assertThat(assets.size(), equalTo(1));
assertThat(assets.get(0).getName(), equalTo("LICENSE.txt"));