From 944d92bbb408dc7be91fcbe539a21762c6e0491a Mon Sep 17 00:00:00 2001
From: Liam Newman <bitwiseman@gmail.com>
Date: Tue, 25 Feb 2020 20:24:02 -0800
Subject: [PATCH] Make more methods as deprecated

---
 pom.xml                                       |  2 -
 .../github/GHDeploymentStatusBuilder.java     |  1 +
 src/main/java/org/kohsuke/github/GHIssue.java | 12 +---
 .../java/org/kohsuke/github/GHMyself.java     |  1 +
 .../org/kohsuke/github/GHOrganization.java    |  2 +
 .../org/kohsuke/github/GHPullRequest.java     |  2 +
 .../kohsuke/github/GHPullRequestReview.java   |  1 +
 .../github/GHPullRequestReviewComment.java    |  1 +
 .../java/org/kohsuke/github/GHRelease.java    |  1 +
 .../java/org/kohsuke/github/GHRepository.java | 58 +++++++++----------
 src/main/java/org/kohsuke/github/GitHub.java  | 13 ++++-
 .../org/kohsuke/github/GHRepositoryTest.java  |  2 +-
 12 files changed, 51 insertions(+), 45 deletions(-)

diff --git a/pom.xml b/pom.xml
index 737aa5a1c..19fb607c5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -160,7 +160,6 @@
                       <exclude>org.kohsuke.github.GHRelease</exclude>
 
                       <!-- TODO: These still need test coverage -->
-                      <exclude>org.kohsuke.github.GitHubClient.GHApiInfo</exclude>
                       <exclude>org.kohsuke.github.GHBranchProtection.RequiredSignatures</exclude>
                       <exclude>org.kohsuke.github.GHBranchProtectionBuilder.Restrictions</exclude>
                       <exclude>org.kohsuke.github.GHBranchProtection.Restrictions</exclude>
@@ -201,7 +200,6 @@
                       <exclude>org.kohsuke.github.GHTeam.Role</exclude>
                       <exclude>org.kohsuke.github.GHUserSearchBuilder.Sort</exclude>
                       <exclude>org.kohsuke.github.GHVerifiedKey</exclude>
-                      <exclude>org.kohsuke.github.GitHubBuilder.1</exclude>
                     </excludes>
                   </rule>
                 </rules>
diff --git a/src/main/java/org/kohsuke/github/GHDeploymentStatusBuilder.java b/src/main/java/org/kohsuke/github/GHDeploymentStatusBuilder.java
index 34ff201a3..af419840e 100644
--- a/src/main/java/org/kohsuke/github/GHDeploymentStatusBuilder.java
+++ b/src/main/java/org/kohsuke/github/GHDeploymentStatusBuilder.java
@@ -23,6 +23,7 @@ public class GHDeploymentStatusBuilder {
      *            the state
      * @deprecated Use {@link GHDeployment#createStatus(GHDeploymentState)}
      */
+    @Deprecated
     public GHDeploymentStatusBuilder(GHRepository repo, int deploymentId, GHDeploymentState state) {
         this(repo, (long) deploymentId, state);
     }
diff --git a/src/main/java/org/kohsuke/github/GHIssue.java b/src/main/java/org/kohsuke/github/GHIssue.java
index 051e36732..14f1818b3 100644
--- a/src/main/java/org/kohsuke/github/GHIssue.java
+++ b/src/main/java/org/kohsuke/github/GHIssue.java
@@ -64,7 +64,7 @@ public class GHIssue extends GHObject implements Reactable {
     @SkipFromToString
     protected String body;
     // for backward compatibility with < 1.63, this collection needs to hold instances of Label, not GHLabel
-    protected List<Label> labels;
+    protected List<GHLabel> labels;
     protected GHUser user;
     protected String title, html_url;
     protected GHIssue.PullRequest pull_request;
@@ -72,14 +72,6 @@ public class GHIssue extends GHObject implements Reactable {
     protected GHUser closed_by;
     protected boolean locked;
 
-    /**
-     * The type Label.
-     *
-     * @deprecated use {@link GHLabel}
-     */
-    public static class Label extends GHLabel {
-    }
-
     GHIssue wrap(GHRepository owner) {
         this.owner = owner;
         if (milestone != null)
@@ -172,7 +164,7 @@ public class GHIssue extends GHObject implements Reactable {
         if (labels == null) {
             return Collections.emptyList();
         }
-        return Collections.<GHLabel>unmodifiableList(labels);
+        return Collections.unmodifiableList(labels);
     }
 
     /**
diff --git a/src/main/java/org/kohsuke/github/GHMyself.java b/src/main/java/org/kohsuke/github/GHMyself.java
index f394bec52..051c811bf 100644
--- a/src/main/java/org/kohsuke/github/GHMyself.java
+++ b/src/main/java/org/kohsuke/github/GHMyself.java
@@ -189,6 +189,7 @@ public class GHMyself extends GHUser {
      * @return the paged iterable
      * @deprecated Use {@link #listRepositories()}
      */
+    @Deprecated
     public PagedIterable<GHRepository> listAllRepositories() {
         return listRepositories();
     }
diff --git a/src/main/java/org/kohsuke/github/GHOrganization.java b/src/main/java/org/kohsuke/github/GHOrganization.java
index 41fbc9d35..cbe39e01c 100644
--- a/src/main/java/org/kohsuke/github/GHOrganization.java
+++ b/src/main/java/org/kohsuke/github/GHOrganization.java
@@ -38,6 +38,7 @@ public class GHOrganization extends GHPerson {
      *             the io exception
      * @deprecated Use {@link #createRepository(String)} that uses a builder pattern to let you control every aspect.
      */
+    @Deprecated
     public GHRepository createRepository(String name,
             String description,
             String homepage,
@@ -67,6 +68,7 @@ public class GHOrganization extends GHPerson {
      *             the io exception
      * @deprecated Use {@link #createRepository(String)} that uses a builder pattern to let you control every aspect.
      */
+    @Deprecated
     public GHRepository createRepository(String name,
             String description,
             String homepage,
diff --git a/src/main/java/org/kohsuke/github/GHPullRequest.java b/src/main/java/org/kohsuke/github/GHPullRequest.java
index c8a18de6e..6371d8ad2 100644
--- a/src/main/java/org/kohsuke/github/GHPullRequest.java
+++ b/src/main/java/org/kohsuke/github/GHPullRequest.java
@@ -452,6 +452,7 @@ public class GHPullRequest extends GHIssue implements Refreshable {
      *             the io exception
      * @deprecated Use {@link #createReview()}
      */
+    @Deprecated
     public GHPullRequestReview createReview(String body,
             @CheckForNull GHPullRequestReviewState event,
             GHPullRequestReviewComment... comments) throws IOException {
@@ -472,6 +473,7 @@ public class GHPullRequest extends GHIssue implements Refreshable {
      *             the io exception
      * @deprecated Use {@link #createReview()}
      */
+    @Deprecated
     public GHPullRequestReview createReview(String body,
             @CheckForNull GHPullRequestReviewState event,
             List<GHPullRequestReviewComment> comments) throws IOException {
diff --git a/src/main/java/org/kohsuke/github/GHPullRequestReview.java b/src/main/java/org/kohsuke/github/GHPullRequestReview.java
index a5e528d74..771c09512 100644
--- a/src/main/java/org/kohsuke/github/GHPullRequestReview.java
+++ b/src/main/java/org/kohsuke/github/GHPullRequestReview.java
@@ -145,6 +145,7 @@ public class GHPullRequestReview extends GHObject {
      * @deprecated Former preview method that changed when it got public. Left here for backward compatibility. Use
      *             {@link #submit(String, GHPullRequestReviewEvent)}
      */
+    @Deprecated
     public void submit(String body, GHPullRequestReviewState state) throws IOException {
         submit(body, state.toEvent());
     }
diff --git a/src/main/java/org/kohsuke/github/GHPullRequestReviewComment.java b/src/main/java/org/kohsuke/github/GHPullRequestReviewComment.java
index 531d4de3c..2208cb157 100644
--- a/src/main/java/org/kohsuke/github/GHPullRequestReviewComment.java
+++ b/src/main/java/org/kohsuke/github/GHPullRequestReviewComment.java
@@ -59,6 +59,7 @@ public class GHPullRequestReviewComment extends GHObject implements Reactable {
      * @return the gh pull request review comment
      * @deprecated You should be using {@link GHPullRequestReviewBuilder#comment(String, String, int)}
      */
+    @Deprecated
     public static GHPullRequestReviewComment draft(String body, String path, int position) {
         GHPullRequestReviewComment result = new GHPullRequestReviewComment();
         result.body = body;
diff --git a/src/main/java/org/kohsuke/github/GHRelease.java b/src/main/java/org/kohsuke/github/GHRelease.java
index 2371bb292..051811832 100644
--- a/src/main/java/org/kohsuke/github/GHRelease.java
+++ b/src/main/java/org/kohsuke/github/GHRelease.java
@@ -71,6 +71,7 @@ public class GHRelease extends GHObject {
      *             the io exception
      * @deprecated Use {@link #update()}
      */
+    @Deprecated
     public GHRelease setDraft(boolean draft) throws IOException {
         return update().draft(draft).update();
     }
diff --git a/src/main/java/org/kohsuke/github/GHRepository.java b/src/main/java/org/kohsuke/github/GHRepository.java
index 6e1bbd2b6..cf0fc75f7 100644
--- a/src/main/java/org/kohsuke/github/GHRepository.java
+++ b/src/main/java/org/kohsuke/github/GHRepository.java
@@ -117,6 +117,7 @@ public class GHRepository extends GHObject {
      *             the io exception
      * @deprecated Use {@code getDeployment(id).listStatuses()}
      */
+    @Deprecated
     public PagedIterable<GHDeploymentStatus> getDeploymentStatuses(final int id) throws IOException {
         return getDeployment(id).listStatuses();
     }
@@ -172,6 +173,7 @@ public class GHRepository extends GHObject {
      *             the io exception
      * @deprecated Use {@code getDeployment(deploymentId).createStatus(ghDeploymentState)}
      */
+    @Deprecated
     public GHDeploymentStatusBuilder createDeployStatus(int deploymentId, GHDeploymentState ghDeploymentState)
             throws IOException {
         return getDeployment(deploymentId).createStatus(ghDeploymentState);
@@ -217,16 +219,6 @@ public class GHRepository extends GHObject {
         return clone_url;
     }
 
-    /**
-     * Git http transport url string.
-     *
-     * @return the string
-     * @deprecated Typo of {@link #getHttpTransportUrl()}
-     */
-    public String gitHttpTransportUrl() {
-        return clone_url;
-    }
-
     /**
      * Gets the Subversion URL to access this repository: https://github.com/rails/rails
      *
@@ -621,8 +613,20 @@ public class GHRepository extends GHObject {
      * and so on.
      *
      * @return the forks
+     * @deprecated use {@link #getForksCount()} instead
      */
+    @Deprecated
     public int getForks() {
+        return getForksCount();
+    }
+
+    /**
+     * Returns the number of all forks of this repository. This not only counts direct forks, but also forks of forks,
+     * and so on.
+     *
+     * @return the forks
+     */
+    public int getForksCount() {
         return forks_count;
     }
 
@@ -666,8 +670,19 @@ public class GHRepository extends GHObject {
      * Gets watchers.
      *
      * @return the watchers
+     * @deprecated use {@link #getWatchersCount()} instead
      */
+    @Deprecated
     public int getWatchers() {
+        return getWatchersCount();
+    }
+
+    /**
+     * Gets the count of watchers.
+     *
+     * @return the watchers
+     */
+    public int getWatchersCount() {
         return watchers_count;
     }
 
@@ -680,16 +695,6 @@ public class GHRepository extends GHObject {
         return open_issues_count;
     }
 
-    /**
-     * Gets network count.
-     *
-     * @return the network count
-     * @deprecated This no longer exists in the official API documentation. Use {@link #getForks()}
-     */
-    public int getNetworkCount() {
-        return forks_count;
-    }
-
     /**
      * Gets subscribers count.
      *
@@ -723,6 +728,7 @@ public class GHRepository extends GHObject {
      * @return the master branch
      * @deprecated Renamed to {@link #getDefaultBranch()}
      */
+    @Deprecated
     public String getMasterBranch() {
         return default_branch;
     }
@@ -1277,6 +1283,7 @@ public class GHRepository extends GHObject {
      * @return the paged iterable
      * @deprecated Use {@link #queryPullRequests()}
      */
+    @Deprecated
     public PagedIterable<GHPullRequest> listPullRequests(GHIssueState state) {
         return queryPullRequests().state(state).list();
     }
@@ -1999,14 +2006,6 @@ public class GHRepository extends GHObject {
         return createWebHook(url, null);
     }
 
-    // this is no different from getPullRequests(OPEN)
-    // /**
-    // * Retrieves all the pull requests.
-    // */
-    // public List<GHPullRequest> getPullRequests() throws IOException {
-    // return root.retrieveWithAuth("/pulls/"+owner+'/'+name,JsonPullRequests.class).wrap(root);
-    // }
-
     /**
      * Returns a set that represents the post-commit hook URLs. The returned set is live, and changes made to them are
      * reflected to GitHub.
@@ -2016,6 +2015,7 @@ public class GHRepository extends GHObject {
      */
     @SuppressFBWarnings(value = "DMI_COLLECTION_OF_URLS",
             justification = "It causes a performance degradation, but we have already exposed it to the API")
+    @Deprecated
     public Set<URL> getPostCommitHooks() {
         return postCommitHooks;
     }
@@ -2029,7 +2029,7 @@ public class GHRepository extends GHObject {
     private final Set<URL> postCommitHooks = new AbstractSet<URL>() {
         private List<URL> getPostCommitHooks() {
             try {
-                List<URL> r = new ArrayList<URL>();
+                List<URL> r = new ArrayList<>();
                 for (GHHook h : getHooks()) {
                     if (h.getName().equals("web")) {
                         r.add(new URL(h.getConfig().get("url")));
diff --git a/src/main/java/org/kohsuke/github/GitHub.java b/src/main/java/org/kohsuke/github/GitHub.java
index 2e5d3510c..6d904e456 100644
--- a/src/main/java/org/kohsuke/github/GitHub.java
+++ b/src/main/java/org/kohsuke/github/GitHub.java
@@ -137,7 +137,10 @@ public class GitHub {
      * Version that connects to GitHub Enterprise.
      *
      * @param apiUrl
-     *            the api url
+     *            The URL of GitHub (or GitHub Enterprise) API endpoint, such as "https://api.github.com" or
+     *            "http://ghe.acme.com/api/v3". Note that GitHub Enterprise has <code>/api/v3</code> in the URL. For
+     *            historical reasons, this parameter still accepts the bare domain name, but that's considered
+     *            deprecated.
      * @param oauthAccessToken
      *            the oauth access token
      * @return the git hub
@@ -217,8 +220,7 @@ public class GitHub {
      * @return the git hub
      * @throws IOException
      *             the io exception
-     * @deprecated Either OAuth token or password is sufficient, so there's no point in passing both. Use
-     *             {@link #connectUsingPassword(String, String)} or {@link #connectUsingOAuth(String)}.
+     * @deprecated Use {@link #connectUsingOAuth(String)}.
      */
     @Deprecated
     public static GitHub connect(String login, String oauthAccessToken, String password) throws IOException {
@@ -235,7 +237,12 @@ public class GitHub {
      * @return the git hub
      * @throws IOException
      *             the io exception
+     * @deprecated Use {@link #connectUsingOAuth(String)} instead.
+     * @see <a href=
+     *      "https://developer.github.com/changes/2020-02-14-deprecating-password-auth/#changes-to-make">Deprecating
+     *      password authentication and OAuth authorizations API</a>
      */
+    @Deprecated
     public static GitHub connectUsingPassword(String login, String password) throws IOException {
         return new GitHubBuilder().withPassword(login, password).build();
     }
diff --git a/src/test/java/org/kohsuke/github/GHRepositoryTest.java b/src/test/java/org/kohsuke/github/GHRepositoryTest.java
index c596f8cd9..52df5205d 100644
--- a/src/test/java/org/kohsuke/github/GHRepositoryTest.java
+++ b/src/test/java/org/kohsuke/github/GHRepositoryTest.java
@@ -477,7 +477,7 @@ public class GHRepositoryTest extends AbstractGitHubWireMockTest {
     public void checkWatchersCount() throws Exception {
         snapshotNotAllowed();
         GHRepository repo = getTempRepository();
-        int watchersCount = repo.getWatchers();
+        int watchersCount = repo.getWatchersCount();
         assertEquals(10, watchersCount);
     }