diff --git a/.github/workflows/maven-build.yml b/.github/workflows/maven-build.yml index 8a086a74e..f009de37c 100644 --- a/.github/workflows/maven-build.yml +++ b/.github/workflows/maven-build.yml @@ -19,4 +19,4 @@ jobs: - name: Maven Download all dependencies run: mvn -B org.apache.maven.plugins:maven-dependency-plugin:3.1.1:go-offline - name: Maven Build - run: mvn -B package --file pom.xml + run: mvn -B install site --file pom.xml diff --git a/pom.xml b/pom.xml index 4f1be9cf7..a0acf7cc2 100644 --- a/pom.xml +++ b/pom.xml @@ -60,9 +60,45 @@ jacoco-maven-plugin 0.8.5 + + org.apache.maven.plugins + maven-javadoc-plugin + 3.1.1 + + + + org.apache.maven.plugins + maven-site-plugin + 3.8.2 + + + maven-release-plugin + 2.5.3 + + release + + + + org.apache.maven.plugins + maven-project-info-reports-plugin + 3.0.0 + + + org.apache.bcel + bcel + 6.4.1 + + + + + org.apache.maven.plugins + maven-source-plugin + 3.1.0 + + maven-compiler-plugin 3.8.1 @@ -217,7 +253,7 @@ org.eclipse.jgit org.eclipse.jgit - 5.5.1.201910021850-r + 5.4.3.201909031940-r test @@ -292,7 +328,7 @@ jacoco - !jacoco.disabled + enable-jacoco @@ -392,6 +428,10 @@ org.apache.maven.plugins maven-javadoc-plugin + + org.apache.maven.plugins + maven-project-info-reports-plugin + diff --git a/src/main/java/org/kohsuke/github/AbuseLimitHandler.java b/src/main/java/org/kohsuke/github/AbuseLimitHandler.java index 7d4d0e4b6..2c21cdaf9 100644 --- a/src/main/java/org/kohsuke/github/AbuseLimitHandler.java +++ b/src/main/java/org/kohsuke/github/AbuseLimitHandler.java @@ -27,6 +27,7 @@ public abstract class AbuseLimitHandler { * this exception (or wrap this exception into another exception and throw it). * @param uc * Connection that resulted in an error. Useful for accessing other response headers. + * @throws IOException */ public abstract void onError(IOException e, HttpURLConnection uc) throws IOException; @@ -38,7 +39,7 @@ public abstract class AbuseLimitHandler { public void onError(IOException e, HttpURLConnection uc) throws IOException { try { Thread.sleep(parseWaitTime(uc)); - } catch (InterruptedException _) { + } catch (InterruptedException ex) { throw (InterruptedIOException)new InterruptedIOException().initCause(e); } } diff --git a/src/main/java/org/kohsuke/github/GHApp.java b/src/main/java/org/kohsuke/github/GHApp.java index 43ad91c5e..d3a73354b 100644 --- a/src/main/java/org/kohsuke/github/GHApp.java +++ b/src/main/java/org/kohsuke/github/GHApp.java @@ -104,6 +104,7 @@ public class GHApp extends GHObject { * You must use a JWT to access this endpoint. * * @see List installations + * @return a list of App installations */ @Preview @Deprecated public PagedIterable listInstallations() { diff --git a/src/main/java/org/kohsuke/github/GHProject.java b/src/main/java/org/kohsuke/github/GHProject.java index 6645a05a3..66e347cbc 100644 --- a/src/main/java/org/kohsuke/github/GHProject.java +++ b/src/main/java/org/kohsuke/github/GHProject.java @@ -32,7 +32,7 @@ import static org.kohsuke.github.Previews.INERTIA; /** * A GitHub project. - * @see https://developer.github.com/v3/projects/ + * @see Projects * @author Martin van Zijl */ public class GHProject extends GHObject { diff --git a/src/main/java/org/kohsuke/github/GitHub.java b/src/main/java/org/kohsuke/github/GitHub.java index 0cbf42597..1c43ef684 100644 --- a/src/main/java/org/kohsuke/github/GitHub.java +++ b/src/main/java/org/kohsuke/github/GitHub.java @@ -551,7 +551,7 @@ public class GitHub { * * To retrieve full organization details, you need to call {@link #getOrganization(String)} * - * @param user the user to retrieve public Organization membership information for + * @param login the user to retrieve public Organization membership information for * * @return the public Organization memberships for the user */