jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-04-04 08:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed GHContent to allow spaces in path

Browse Source 
URI path encoding whack-a-mole.  This fix should cover a significant number of cases.

Also, fixed to NOT do URLEncode for URI path.  The encoding is different between path and query.

Fixes #624
This commit is contained in:
Liam Newman
2019-11-25 14:34:39 -08:00
parent 7d4f1941e7
commit 8c4b1ef74a
59 changed files with 1375 additions and 1074 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/test/java/org/kohsuke/github/GHContentIntegrationTest.java
View File

@@ -9,13 +9,18 @@ import java.io.IOException;
import java.io.InputStreamReader;
import java.util.List;
import static org.hamcrest.CoreMatchers.*;
/**
* Integration test for {@link GHContent}.
*/
public class GHContentIntegrationTest extends AbstractGitHubWireMockTest {
private GHRepository repo;
private String createdFilename = "test-file-to-create.txt";
// file name with spaces and other chars
private final String createdDirectory = "test+directory #50";
private final String createdFilename = createdDirectory + "/test file-to+create-#1.txt";
@Before
@After
@@ -79,8 +84,23 @@ public class GHContentIntegrationTest extends AbstractGitHubWireMockTest {
assertNotNull(created.getCommit());
assertNotNull(created.getContent());
assertNotNull(createdContent.getContent());
assertThat(createdContent.getPath(), equalTo(createdFilename));
assertEquals("this is an awesome file I created\n", createdContent.getContent());
GHContent content = repo.getFileContent(createdFilename);
assertThat(content, is(notNullValue()));
assertThat(content.getSha(), equalTo(createdContent.getSha()));
assertThat(content.getContent(), equalTo(createdContent.getContent()));
assertThat(content.getPath(), equalTo(createdContent.getPath()));
List<GHContent> directoryContents = repo.getDirectoryContent(createdDirectory);
assertThat(directoryContents, is(notNullValue()));
assertThat(directoryContents.size(), equalTo(1));
content = directoryContents.get(0);
assertThat(content.getSha(), is(created.getContent().getSha()));
assertThat(content.getContent(), is(created.getContent().getContent()));
assertThat(content.getPath(), equalTo(createdFilename));
GHContentUpdateResponse updatedContentResponse = createdContent.update("this is some new content\n",
"Updated file for integration tests.");
GHContent updatedContent = updatedContentResponse.getContent();
@@ -96,5 +116,13 @@ public class GHContentIntegrationTest extends AbstractGitHubWireMockTest {
assertNotNull(deleteResponse.getCommit());
assertNull(deleteResponse.getContent());
try {
repo.getFileContent(createdFilename);
fail("Delete didn't work!");
} catch (GHFileNotFoundException e) {
assertThat(e.getMessage(),
equalTo("{\"message\":\"Not Found\",\"documentation_url\":\"https://developer.github.com/v3/repos/contents/#get-contents\"}"));
}
}
}