From 83ffe75baaf2b61ba41ee8bacf93264690c07cab Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Wed, 2 Dec 2015 12:03:39 +0100 Subject: [PATCH] Fixed rate handling limit handling Issue #220. If RateLimitHandler returns normally, it should retry. --- src/main/java/org/kohsuke/github/Requester.java | 1 + src/test/java/Foo.java | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/main/java/org/kohsuke/github/Requester.java b/src/main/java/org/kohsuke/github/Requester.java index 81fe507d8..b1e750ff7 100644 --- a/src/main/java/org/kohsuke/github/Requester.java +++ b/src/main/java/org/kohsuke/github/Requester.java @@ -501,6 +501,7 @@ class Requester { if ("0".equals(uc.getHeaderField("X-RateLimit-Remaining"))) { root.rateLimitHandler.onError(e,uc); + return; } InputStream es = wrapStream(uc.getErrorStream()); diff --git a/src/test/java/Foo.java b/src/test/java/Foo.java index 5df13995c..a29baac4b 100644 --- a/src/test/java/Foo.java +++ b/src/test/java/Foo.java @@ -1,4 +1,5 @@ import org.kohsuke.github.GHRepository; +import org.kohsuke.github.GHUser; import org.kohsuke.github.GitHub; import java.util.Collection; @@ -14,4 +15,11 @@ public class Foo { } System.out.println(lst.size()); } + + private static void testRateLimit() throws Exception { + GitHub g = GitHub.connectAnonymously(); + for (GHUser u : g.getOrganization("jenkinsci").listMembers()) { + u.getFollowersCount(); + } + } }