GHPullRequest.getLabels should not go to the GHIssue API endpoint

This commit is contained in:
Jesse Glick
2020-10-15 13:25:20 -04:00
parent f1ca0b5417
commit 8267050f06
2 changed files with 1 additions and 23 deletions

View File

@@ -158,10 +158,8 @@ public class GHIssue extends GHObject implements Reactable {
* Gets labels.
*
* @return the labels
* @throws IOException
* the io exception
*/
public Collection<GHLabel> getLabels() throws IOException {
public Collection<GHLabel> getLabels() {
if (labels == null) {
return Collections.emptyList();
}

View File

@@ -29,7 +29,6 @@ import java.io.IOException;
import java.net.URL;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
import java.util.List;
@@ -73,13 +72,6 @@ public class GHPullRequest extends GHIssue implements Refreshable {
private GHUser[] requested_reviewers;
private GHTeam[] requested_teams;
/**
* GitHub doesn't return some properties of {@link GHIssue} when requesting the GET on the 'pulls' API route as
* opposed to 'issues' API route. This flag remembers whether we made the GET call on the 'issues' route on this
* object to fill in those missing details
*/
private transient boolean fetchedIssueDetails;
GHPullRequest wrapUp(GHRepository owner) {
this.wrap(owner);
return wrapUp(owner.root);
@@ -178,12 +170,6 @@ public class GHPullRequest extends GHIssue implements Refreshable {
return GitHubClient.parseDate(merged_at);
}
@Override
public Collection<GHLabel> getLabels() throws IOException {
fetchIssue();
return super.getLabels();
}
@Override
public GHUser getClosedBy() {
return null;
@@ -662,10 +648,4 @@ public class GHPullRequest extends GHIssue implements Refreshable {
MERGE, SQUASH, REBASE
}
private void fetchIssue() throws IOException {
if (!fetchedIssueDetails) {
root.createRequest().withUrlPath(getIssuesApiRoute()).fetchInto(this);
fetchedIssueDetails = true;
}
}
}