jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-04-04 08:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up request method calls

Browse Source
This commit is contained in:
Liam Newman
2019-12-16 11:18:56 -08:00
parent 0f9482864c
commit 40f05e4dbb
28 changed files with 66 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/main/java/org/kohsuke/github/Requester.java
View File

@@ -500,26 +500,24 @@ class Requester {
}
/**
* Makes a request and just obtains the HTTP status code.
* Makes a request and just obtains the HTTP status code. Method does not throw exceptions for many status codes
* that would otherwise throw.
*
* @param tailApiUrl
* the tail api url
* @return the int
* @throws IOException
* the io exception
*/
public int asHttpStatusCode(String tailApiUrl) throws IOException {
public int asHttpStatusCode() throws IOException {
while (true) {// loop while API rate limit is hit
method("GET");
setupConnection(root.getApiURL(tailApiUrl));
setupConnection(root.getApiURL(urlPath));
try {
return uc.getResponseCode();
} catch (IOException e) {
handleApiError(e);
} finally {
noteRateLimit(tailApiUrl);
noteRateLimit(urlPath);
}
}
}
@@ -527,22 +525,20 @@ class Requester {
/**
* As stream input stream.
*
* @param tailApiUrl
* the tail api url
* @return the input stream
* @throws IOException
* the io exception
*/
public InputStream asStream(String tailApiUrl) throws IOException {
public InputStream toStream() throws IOException {
while (true) {// loop while API rate limit is hit
setupConnection(root.getApiURL(tailApiUrl));
setupConnection(root.getApiURL(urlPath));
try {
return wrapStream(uc.getInputStream());
} catch (IOException e) {
handleApiError(e);
} finally {
noteRateLimit(tailApiUrl);
noteRateLimit(urlPath);
}
}
}
@@ -689,7 +685,9 @@ class Requester {
* Every iterator call reports a new batch.
*/
<T> Iterator<T> asIterator(Class<T> type, int pageSize) {
method("GET");
if (method != "GET") {
throw new IllegalStateException("Request method \"GET\" is required for iterator.");
}
if (pageSize != 0)
args.add(new Entry("per_page", pageSize));