jlengrand/github-api
1
0
Fork 0
mirror of https://github.com/jlengrand/github-api.git synced 2026-04-04 15:50:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Returning null instead of throwing an exception (as a matter of taste)

Browse Source
This commit is contained in:
Kohsuke Kawaguchi
2015-04-13 16:39:20 -07:00
parent 8dcea59c74
commit 1a071b0b54
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/org/kohsuke/github/GHThread.java
View File

@@ -59,23 +59,38 @@ public class GHThread extends GHObject {
return subject.type;
}
/**
* If this thread is about an issue, return that issue.
*
* @return null if this thread is not about an issue.
*/
public GHIssue getBoundIssue() throws IOException {
if (!"Issue".equals(subject.type))
throw new IllegalStateException("Notification doesn't point to Issue");
if (!"Issue".equals(subject.type) && "PullRequest".equals(subject.type))
return null;
return repository.getIssue(
Integer.parseInt(subject.url.substring(subject.url.lastIndexOf('/') + 1)));
}
/**
* If this thread is about a pull request, return that pull request.
*
* @return null if this thread is not about a pull request.
*/
public GHPullRequest getBoundPullRequest() throws IOException {
if (!"PullRequest".equals(subject.type))
throw new IllegalStateException("Notification doesn't point to PullRequest");
return null;
return repository.getPullRequest(
Integer.parseInt(subject.url.substring(subject.url.lastIndexOf('/') + 1)));
}
/**
* If this thread is about a commit, return that commit.
*
* @return null if this thread is not about a commit.
*/
public GHCommit getBoundCommit() throws IOException {
if (!"Commit".equals(subject.type))
throw new IllegalStateException("Notification doesn't point to Commit");
return null;
return repository.getCommit(subject.url.substring(subject.url.lastIndexOf('/') + 1));
}