From 17edd33703a323ebec53dfc912eb3028826105c7 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Sat, 9 Sep 2017 12:00:23 -0700 Subject: [PATCH] Reorganized imports following #337 --- .../org/kohsuke/github/GHAuthorization.java | 1 + .../java/org/kohsuke/github/GHBranch.java | 7 +++---- .../kohsuke/github/GHBranchProtection.java | 5 ++--- .../github/GHBranchProtectionBuilder.java | 4 ++-- .../java/org/kohsuke/github/GHCommit.java | 1 + .../org/kohsuke/github/GHCommitComment.java | 4 +++- .../kohsuke/github/GHCommitSearchBuilder.java | 4 ++-- .../java/org/kohsuke/github/GHDeployKey.java | 4 ++-- .../java/org/kohsuke/github/GHEventInfo.java | 6 +++--- .../org/kohsuke/github/GHEventPayload.java | 1 + src/main/java/org/kohsuke/github/GHHook.java | 1 + .../org/kohsuke/github/GHIssueComment.java | 2 +- .../java/org/kohsuke/github/GHLicense.java | 2 +- .../java/org/kohsuke/github/GHObject.java | 1 + .../org/kohsuke/github/GHPullRequest.java | 4 ++-- .../kohsuke/github/GHPullRequestReview.java | 2 +- .../java/org/kohsuke/github/GHRateLimit.java | 1 + .../java/org/kohsuke/github/GHReaction.java | 2 +- src/main/java/org/kohsuke/github/GHRef.java | 1 + .../java/org/kohsuke/github/GHRelease.java | 2 +- .../java/org/kohsuke/github/GHThread.java | 1 + .../org/kohsuke/github/GHTreeBuilder.java | 3 ++- src/main/java/org/kohsuke/github/GitHub.java | 20 +++++++++---------- src/main/java/org/kohsuke/github/GitUser.java | 1 + .../org/kohsuke/github/HttpException.java | 3 +-- .../java/org/kohsuke/github/Requester.java | 15 +++++++------- 26 files changed, 54 insertions(+), 44 deletions(-) diff --git a/src/main/java/org/kohsuke/github/GHAuthorization.java b/src/main/java/org/kohsuke/github/GHAuthorization.java index e19604777..bf7e24c7f 100644 --- a/src/main/java/org/kohsuke/github/GHAuthorization.java +++ b/src/main/java/org/kohsuke/github/GHAuthorization.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.net.URL; import java.util.Collection; import java.util.List; diff --git a/src/main/java/org/kohsuke/github/GHBranch.java b/src/main/java/org/kohsuke/github/GHBranch.java index c2e5b2944..1ce9c29ac 100644 --- a/src/main/java/org/kohsuke/github/GHBranch.java +++ b/src/main/java/org/kohsuke/github/GHBranch.java @@ -1,14 +1,13 @@ package org.kohsuke.github; -import static org.kohsuke.github.Previews.LOKI; +import com.fasterxml.jackson.annotation.JsonProperty; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.IOException; import java.net.URL; import java.util.Collection; -import com.fasterxml.jackson.annotation.JsonProperty; - -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import static org.kohsuke.github.Previews.*; /** * A branch in a repository. diff --git a/src/main/java/org/kohsuke/github/GHBranchProtection.java b/src/main/java/org/kohsuke/github/GHBranchProtection.java index 321636611..7e43bd69c 100644 --- a/src/main/java/org/kohsuke/github/GHBranchProtection.java +++ b/src/main/java/org/kohsuke/github/GHBranchProtection.java @@ -1,11 +1,10 @@ package org.kohsuke.github; -import java.util.Collection; - import com.fasterxml.jackson.annotation.JsonProperty; - import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.util.Collection; + @SuppressFBWarnings(value = { "UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD", "UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "URF_UNREAD_FIELD" }, justification = "JSON API") public class GHBranchProtection { diff --git a/src/main/java/org/kohsuke/github/GHBranchProtectionBuilder.java b/src/main/java/org/kohsuke/github/GHBranchProtectionBuilder.java index 5fccf7eb8..dc7dbd884 100644 --- a/src/main/java/org/kohsuke/github/GHBranchProtectionBuilder.java +++ b/src/main/java/org/kohsuke/github/GHBranchProtectionBuilder.java @@ -1,6 +1,6 @@ package org.kohsuke.github; -import static org.kohsuke.github.Previews.LOKI; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.IOException; import java.util.ArrayList; @@ -12,7 +12,7 @@ import java.util.List; import java.util.Map; import java.util.Set; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import static org.kohsuke.github.Previews.*; /** * Builder to configure the branch protection settings. diff --git a/src/main/java/org/kohsuke/github/GHCommit.java b/src/main/java/org/kohsuke/github/GHCommit.java index ec5dfbffc..a817da2fd 100644 --- a/src/main/java/org/kohsuke/github/GHCommit.java +++ b/src/main/java/org/kohsuke/github/GHCommit.java @@ -2,6 +2,7 @@ package org.kohsuke.github; import com.infradna.tool.bridge_method_injector.WithBridgeMethods; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.IOException; import java.net.URL; import java.util.AbstractList; diff --git a/src/main/java/org/kohsuke/github/GHCommitComment.java b/src/main/java/org/kohsuke/github/GHCommitComment.java index 646badf5c..f5ee76e47 100644 --- a/src/main/java/org/kohsuke/github/GHCommitComment.java +++ b/src/main/java/org/kohsuke/github/GHCommitComment.java @@ -1,9 +1,11 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.IOException; import java.net.URL; -import static org.kohsuke.github.Previews.SQUIRREL_GIRL; + +import static org.kohsuke.github.Previews.*; /** * A comment attached to a commit (or a specific line in a specific file of a commit.) diff --git a/src/main/java/org/kohsuke/github/GHCommitSearchBuilder.java b/src/main/java/org/kohsuke/github/GHCommitSearchBuilder.java index 65136dc0a..23960528f 100644 --- a/src/main/java/org/kohsuke/github/GHCommitSearchBuilder.java +++ b/src/main/java/org/kohsuke/github/GHCommitSearchBuilder.java @@ -1,9 +1,9 @@ package org.kohsuke.github; -import java.io.IOException; - import org.apache.commons.lang.StringUtils; +import java.io.IOException; + /** * Search commits. * diff --git a/src/main/java/org/kohsuke/github/GHDeployKey.java b/src/main/java/org/kohsuke/github/GHDeployKey.java index eb2c2c00f..bfa03b250 100644 --- a/src/main/java/org/kohsuke/github/GHDeployKey.java +++ b/src/main/java/org/kohsuke/github/GHDeployKey.java @@ -1,9 +1,9 @@ package org.kohsuke.github; -import java.io.IOException; - import org.apache.commons.lang.builder.ToStringBuilder; +import java.io.IOException; + public class GHDeployKey { protected String url, key, title; diff --git a/src/main/java/org/kohsuke/github/GHEventInfo.java b/src/main/java/org/kohsuke/github/GHEventInfo.java index 0268924ea..e875f2df5 100644 --- a/src/main/java/org/kohsuke/github/GHEventInfo.java +++ b/src/main/java/org/kohsuke/github/GHEventInfo.java @@ -1,11 +1,11 @@ package org.kohsuke.github; -import java.io.IOException; -import java.util.Date; - import com.fasterxml.jackson.databind.node.ObjectNode; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.io.IOException; +import java.util.Date; + /** * Represents an event. * diff --git a/src/main/java/org/kohsuke/github/GHEventPayload.java b/src/main/java/org/kohsuke/github/GHEventPayload.java index 29f69bb3e..8f5799430 100644 --- a/src/main/java/org/kohsuke/github/GHEventPayload.java +++ b/src/main/java/org/kohsuke/github/GHEventPayload.java @@ -3,6 +3,7 @@ package org.kohsuke.github; import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.annotation.JsonSetter; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.Reader; import java.util.List; diff --git a/src/main/java/org/kohsuke/github/GHHook.java b/src/main/java/org/kohsuke/github/GHHook.java index 4aa32e194..b7f450307 100644 --- a/src/main/java/org/kohsuke/github/GHHook.java +++ b/src/main/java/org/kohsuke/github/GHHook.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.IOException; import java.net.URL; import java.util.Collections; diff --git a/src/main/java/org/kohsuke/github/GHIssueComment.java b/src/main/java/org/kohsuke/github/GHIssueComment.java index a98f6f639..3f4d70643 100644 --- a/src/main/java/org/kohsuke/github/GHIssueComment.java +++ b/src/main/java/org/kohsuke/github/GHIssueComment.java @@ -26,7 +26,7 @@ package org.kohsuke.github; import java.io.IOException; import java.net.URL; -import static org.kohsuke.github.Previews.SQUIRREL_GIRL; +import static org.kohsuke.github.Previews.*; /** * Comment to the issue diff --git a/src/main/java/org/kohsuke/github/GHLicense.java b/src/main/java/org/kohsuke/github/GHLicense.java index 2c5c4299c..a7dad4b5c 100644 --- a/src/main/java/org/kohsuke/github/GHLicense.java +++ b/src/main/java/org/kohsuke/github/GHLicense.java @@ -32,7 +32,7 @@ import java.net.URL; import java.util.ArrayList; import java.util.List; -import static org.kohsuke.github.Previews.DRAX; +import static org.kohsuke.github.Previews.*; /** * The GitHub Preview API's license information diff --git a/src/main/java/org/kohsuke/github/GHObject.java b/src/main/java/org/kohsuke/github/GHObject.java index d368af0ae..e09198190 100644 --- a/src/main/java/org/kohsuke/github/GHObject.java +++ b/src/main/java/org/kohsuke/github/GHObject.java @@ -4,6 +4,7 @@ import com.infradna.tool.bridge_method_injector.WithBridgeMethods; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.apache.commons.lang.builder.ReflectionToStringBuilder; import org.apache.commons.lang.builder.ToStringStyle; + import java.io.IOException; import java.lang.reflect.Field; import java.net.URL; diff --git a/src/main/java/org/kohsuke/github/GHPullRequest.java b/src/main/java/org/kohsuke/github/GHPullRequest.java index 078603d6f..677d6bede 100644 --- a/src/main/java/org/kohsuke/github/GHPullRequest.java +++ b/src/main/java/org/kohsuke/github/GHPullRequest.java @@ -23,6 +23,7 @@ */ package org.kohsuke.github; +import javax.annotation.CheckForNull; import java.io.IOException; import java.net.URL; import java.util.ArrayList; @@ -30,9 +31,8 @@ import java.util.Arrays; import java.util.Collection; import java.util.Date; import java.util.List; -import javax.annotation.CheckForNull; -import static org.kohsuke.github.Previews.BLACK_CAT; +import static org.kohsuke.github.Previews.*; /** * A pull request. diff --git a/src/main/java/org/kohsuke/github/GHPullRequestReview.java b/src/main/java/org/kohsuke/github/GHPullRequestReview.java index b25f28b59..d7afe59aa 100644 --- a/src/main/java/org/kohsuke/github/GHPullRequestReview.java +++ b/src/main/java/org/kohsuke/github/GHPullRequestReview.java @@ -26,7 +26,7 @@ package org.kohsuke.github; import java.io.IOException; import java.net.URL; -import static org.kohsuke.github.Previews.BLACK_CAT; +import static org.kohsuke.github.Previews.*; /** * Review to the pull request diff --git a/src/main/java/org/kohsuke/github/GHRateLimit.java b/src/main/java/org/kohsuke/github/GHRateLimit.java index b9b900d78..9500b0a73 100644 --- a/src/main/java/org/kohsuke/github/GHRateLimit.java +++ b/src/main/java/org/kohsuke/github/GHRateLimit.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.util.Date; /** diff --git a/src/main/java/org/kohsuke/github/GHReaction.java b/src/main/java/org/kohsuke/github/GHReaction.java index 55b26365e..6a00eb305 100644 --- a/src/main/java/org/kohsuke/github/GHReaction.java +++ b/src/main/java/org/kohsuke/github/GHReaction.java @@ -3,7 +3,7 @@ package org.kohsuke.github; import java.io.IOException; import java.net.URL; -import static org.kohsuke.github.Previews.SQUIRREL_GIRL; +import static org.kohsuke.github.Previews.*; /** * Reaction to issue, comment, PR, and so on. diff --git a/src/main/java/org/kohsuke/github/GHRef.java b/src/main/java/org/kohsuke/github/GHRef.java index 8212dc2c3..c8462d3fe 100644 --- a/src/main/java/org/kohsuke/github/GHRef.java +++ b/src/main/java/org/kohsuke/github/GHRef.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.IOException; import java.net.URL; diff --git a/src/main/java/org/kohsuke/github/GHRelease.java b/src/main/java/org/kohsuke/github/GHRelease.java index 96421da41..524bce70b 100644 --- a/src/main/java/org/kohsuke/github/GHRelease.java +++ b/src/main/java/org/kohsuke/github/GHRelease.java @@ -8,7 +8,7 @@ import java.util.Arrays; import java.util.Date; import java.util.List; -import static java.lang.String.format; +import static java.lang.String.*; /** * Release in a github repository. diff --git a/src/main/java/org/kohsuke/github/GHThread.java b/src/main/java/org/kohsuke/github/GHThread.java index a1964b10d..faf4c87b7 100644 --- a/src/main/java/org/kohsuke/github/GHThread.java +++ b/src/main/java/org/kohsuke/github/GHThread.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.io.FileNotFoundException; import java.io.IOException; import java.net.URL; diff --git a/src/main/java/org/kohsuke/github/GHTreeBuilder.java b/src/main/java/org/kohsuke/github/GHTreeBuilder.java index 46fe43b4a..cffbc8eaf 100644 --- a/src/main/java/org/kohsuke/github/GHTreeBuilder.java +++ b/src/main/java/org/kohsuke/github/GHTreeBuilder.java @@ -1,7 +1,8 @@ package org.kohsuke.github; import java.io.IOException; -import java.util.*; +import java.util.ArrayList; +import java.util.List; /** * Builder pattern for creating a new tree. diff --git a/src/main/java/org/kohsuke/github/GitHub.java b/src/main/java/org/kohsuke/github/GitHub.java index 49c860e4d..f9f9f6dec 100644 --- a/src/main/java/org/kohsuke/github/GitHub.java +++ b/src/main/java/org/kohsuke/github/GitHub.java @@ -27,6 +27,12 @@ import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.introspect.VisibilityChecker.Std; import com.infradna.tool.bridge_method_injector.WithBridgeMethods; +import org.apache.commons.codec.Charsets; +import org.apache.commons.codec.binary.Base64; +import org.apache.commons.io.IOUtils; + +import javax.annotation.CheckForNull; +import javax.annotation.Nonnull; import java.io.ByteArrayInputStream; import java.io.FileNotFoundException; import java.io.IOException; @@ -48,17 +54,11 @@ import java.util.Map; import java.util.Set; import java.util.TimeZone; import java.util.logging.Logger; -import javax.annotation.CheckForNull; -import javax.annotation.Nonnull; -import org.apache.commons.codec.Charsets; -import org.apache.commons.codec.binary.Base64; -import org.apache.commons.io.IOUtils; -import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.ANY; -import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.NONE; -import static java.net.HttpURLConnection.HTTP_UNAUTHORIZED; -import static java.util.logging.Level.FINE; -import static org.kohsuke.github.Previews.DRAX; +import static com.fasterxml.jackson.annotation.JsonAutoDetect.Visibility.*; +import static java.net.HttpURLConnection.*; +import static java.util.logging.Level.*; +import static org.kohsuke.github.Previews.*; /** * Root of the GitHub API. diff --git a/src/main/java/org/kohsuke/github/GitUser.java b/src/main/java/org/kohsuke/github/GitUser.java index 751aabd37..9cd50bb22 100644 --- a/src/main/java/org/kohsuke/github/GitUser.java +++ b/src/main/java/org/kohsuke/github/GitUser.java @@ -1,6 +1,7 @@ package org.kohsuke.github; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import java.util.Date; /** diff --git a/src/main/java/org/kohsuke/github/HttpException.java b/src/main/java/org/kohsuke/github/HttpException.java index 16c8e68be..79def83c2 100644 --- a/src/main/java/org/kohsuke/github/HttpException.java +++ b/src/main/java/org/kohsuke/github/HttpException.java @@ -1,11 +1,10 @@ package org.kohsuke.github; +import javax.annotation.CheckForNull; import java.io.IOException; import java.net.HttpURLConnection; import java.net.URL; -import javax.annotation.CheckForNull; - /** * {@link IOException} for http exceptions because {@link HttpURLConnection} throws un-discerned * {@link IOException} and it can help to know the http response code to decide how to handle an diff --git a/src/main/java/org/kohsuke/github/Requester.java b/src/main/java/org/kohsuke/github/Requester.java index beeef0d2e..3e28c342f 100644 --- a/src/main/java/org/kohsuke/github/Requester.java +++ b/src/main/java/org/kohsuke/github/Requester.java @@ -25,6 +25,10 @@ package org.kohsuke.github; import com.fasterxml.jackson.databind.JsonMappingException; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import org.apache.commons.io.IOUtils; +import org.apache.commons.lang.StringUtils; + +import javax.annotation.WillClose; import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; @@ -49,19 +53,16 @@ import java.util.List; import java.util.Locale; import java.util.Map; import java.util.NoSuchElementException; +import java.util.logging.Level; import java.util.logging.Logger; import java.util.regex.Matcher; import java.util.regex.Pattern; import java.util.zip.GZIPInputStream; -import javax.annotation.WillClose; -import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; -import static java.util.Arrays.asList; -import java.util.logging.Level; +import static java.util.Arrays.*; import static java.util.logging.Level.*; -import static org.apache.commons.lang.StringUtils.defaultString; -import static org.kohsuke.github.GitHub.MAPPER; +import static org.apache.commons.lang.StringUtils.*; +import static org.kohsuke.github.GitHub.*; /** * A builder pattern for making HTTP call and parsing its output.