From 0ce78016ccf1a937218e9fa2a59a958c0141599a Mon Sep 17 00:00:00 2001 From: Guillaume Smet Date: Wed, 14 Apr 2021 16:28:46 +0200 Subject: [PATCH] Be more permissive about GHEvent parsing --- src/main/java/org/kohsuke/github/GHEvent.java | 5 +++++ src/main/java/org/kohsuke/github/GHWorkflowRun.java | 2 +- src/test/java/org/kohsuke/github/EnumTest.java | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/kohsuke/github/GHEvent.java b/src/main/java/org/kohsuke/github/GHEvent.java index 754199e1c..ff61f057a 100644 --- a/src/main/java/org/kohsuke/github/GHEvent.java +++ b/src/main/java/org/kohsuke/github/GHEvent.java @@ -67,6 +67,11 @@ public enum GHEvent { WORKFLOW_DISPATCH, WORKFLOW_RUN, + /** + * Special event type that means we haven't found an enum value corresponding to the event. + */ + UNKNOWN, + /** * Special event type that means "every possible event" */ diff --git a/src/main/java/org/kohsuke/github/GHWorkflowRun.java b/src/main/java/org/kohsuke/github/GHWorkflowRun.java index 235f935cf..b66e5a01f 100644 --- a/src/main/java/org/kohsuke/github/GHWorkflowRun.java +++ b/src/main/java/org/kohsuke/github/GHWorkflowRun.java @@ -188,7 +188,7 @@ public class GHWorkflowRun extends GHObject { * @return type of event */ public GHEvent getEvent() { - return Enum.valueOf(GHEvent.class, event.toUpperCase(Locale.ROOT)); + return EnumUtils.getNullableEnumOrDefault(GHEvent.class, event, GHEvent.UNKNOWN); } /** diff --git a/src/test/java/org/kohsuke/github/EnumTest.java b/src/test/java/org/kohsuke/github/EnumTest.java index 171e09c52..a83a6267c 100644 --- a/src/test/java/org/kohsuke/github/EnumTest.java +++ b/src/test/java/org/kohsuke/github/EnumTest.java @@ -27,7 +27,7 @@ public class EnumTest extends AbstractGitHubWireMockTest { assertThat(GHDirection.values().length, equalTo(2)); - assertThat(GHEvent.values().length, equalTo(57)); + assertThat(GHEvent.values().length, equalTo(58)); assertThat(GHEvent.ALL.symbol(), equalTo("*")); assertThat(GHEvent.PULL_REQUEST.symbol(), equalTo(GHEvent.PULL_REQUEST.toString().toLowerCase()));