diff --git a/metrics-jakarta-servlets/src/main/java/io/dropwizard/metrics/servlets/MetricsServlet.java b/metrics-jakarta-servlets/src/main/java/io/dropwizard/metrics/servlets/MetricsServlet.java index a248dd8..4e7f053 100644 --- a/metrics-jakarta-servlets/src/main/java/io/dropwizard/metrics/servlets/MetricsServlet.java +++ b/metrics-jakarta-servlets/src/main/java/io/dropwizard/metrics/servlets/MetricsServlet.java @@ -188,6 +188,7 @@ public class MetricsServlet extends HttpServlet { return mapper.writer(); } + @SuppressWarnings("IdentityConversion") protected TimeUnit parseTimeUnit(String value, TimeUnit defaultValue) { try { return TimeUnit.valueOf(String.valueOf(value).toUpperCase(Locale.US)); diff --git a/metrics-servlets/src/main/java/com/codahale/metrics/servlets/MetricsServlet.java b/metrics-servlets/src/main/java/com/codahale/metrics/servlets/MetricsServlet.java index 0bd1297..7c69a08 100644 --- a/metrics-servlets/src/main/java/com/codahale/metrics/servlets/MetricsServlet.java +++ b/metrics-servlets/src/main/java/com/codahale/metrics/servlets/MetricsServlet.java @@ -189,6 +189,7 @@ public class MetricsServlet extends HttpServlet { return mapper.writer(); } + @SuppressWarnings("IdentityConversion") protected TimeUnit parseTimeUnit(String value, TimeUnit defaultValue) { try { return TimeUnit.valueOf(String.valueOf(value).toUpperCase(Locale.US)); diff --git a/pom.xml b/pom.xml index 6192b52..8c312b6 100644 --- a/pom.xml +++ b/pom.xml @@ -68,7 +68,8 @@ 3.11.0 2.19.1 9+181-r4173-1 - + -Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode ${error-prone.configuration-args} + 8 dropwizard_metrics dropwizard https://sonarcloud.io @@ -166,10 +167,9 @@ org.apache.maven.plugins maven-compiler-plugin - + -Xlint:all -XDcompilePolicy=simple - -Xplugin:ErrorProne -XepExcludedPaths:.*/target/generated-sources/.* -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED @@ -181,18 +181,129 @@ -J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED - - - com.google.errorprone - error_prone_core - ${errorprone.version} - - + + error-prone-compile + + + + org.apache.maven.plugins + maven-compiler-plugin + ${maven-compiler-plugin.version} + + + + default-compile + compile + + compile + + + true + + + + error-prone-compile + compile + + compile + + + true + ${java.version} + ${java.version} + + -Xpkginfo:always + -XDcompilePolicy=simple + ${error-prone-support.flags} + + + + com.google.errorprone + error_prone_core + ${error-prone.version} + + + tech.picnic.error-prone-support + error-prone-contrib + ${error-prone-support.version} + + + tech.picnic.error-prone-support + refaster-runner + ${error-prone-support.version} + + + + + + + + + + + error-prone-test-compile + + + + org.apache.maven.plugins + maven-compiler-plugin + ${maven-compiler-plugin.version} + + + + default-testCompile + test-compile + + testCompile + + + true + + + + error-prone-test-compile + test-compile + + testCompile + + + true + ${java.version} + ${java.version} + + -Xpkginfo:always + -XDcompilePolicy=simple + ${error-prone-support.flags} + + + + com.google.errorprone + error_prone_core + ${error-prone.version} + + + tech.picnic.error-prone-support + error-prone-contrib + ${error-prone-support.version} + + + tech.picnic.error-prone-support + refaster-runner + ${error-prone-support.version} + + + + + + + + + release-sign-artifacts @@ -323,15 +434,7 @@ -Xlint:all -XDcompilePolicy=simple - -Xplugin:ErrorProne -XepExcludedPaths:.*/target/generated-sources/.* - - - com.google.errorprone - error_prone_core - ${errorprone.version} - -