jlengrand/error-prone-support
1
0
Fork 0
mirror of https://github.com/jlengrand/error-prone-support.git synced 2026-03-10 08:11:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract and improve method

Browse Source
This commit is contained in:
Rick Ossendrijver
2023-01-13 12:58:23 +01:00
parent a2626ee8bf
commit fc6af3337d
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/JUnitFactoryMethodDeclaration.java
View File

@@ -67,7 +67,6 @@ import tech.picnic.errorprone.bugpatterns.util.MoreJUnitMatchers;
tags = STYLE) tags = STYLE)
public final class JUnitFactoryMethodDeclaration extends BugChecker implements MethodTreeMatcher { public final class JUnitFactoryMethodDeclaration extends BugChecker implements MethodTreeMatcher {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private static final Matcher<MethodTree> HAS_UNMODIFIABLE_SIGNATURE = private static final Matcher<MethodTree> HAS_UNMODIFIABLE_SIGNATURE =
anyOf( anyOf(
annotations(AT_LEAST_ONE, isType("java.lang.Override")), annotations(AT_LEAST_ONE, isType("java.lang.Override")),
@@ -167,13 +166,7 @@ public final class JUnitFactoryMethodDeclaration extends BugChecker implements M
private ImmutableList<Description> getReturnStatementCommentFixes( private ImmutableList<Description> getReturnStatementCommentFixes(
MethodTree testMethod, MethodTree factoryMethod, VisitorState state) { MethodTree testMethod, MethodTree factoryMethod, VisitorState state) {
ImmutableList<String> parameterNames = String expectedComment = createCommentContainingParameters(testMethod);
testMethod.getParameters().stream()
.map(VariableTree::getName)
.map(Object::toString)
.collect(toImmutableList());
String expectedComment = parameterNames.stream().collect(joining(", ", "/* { ", " } */"));
List<? extends StatementTree> statements = factoryMethod.getBody().getStatements(); List<? extends StatementTree> statements = factoryMethod.getBody().getStatements();
@@ -201,6 +194,13 @@ public final class JUnitFactoryMethodDeclaration extends BugChecker implements M
.collect(toImmutableList()); .collect(toImmutableList());
} }
private static String createCommentContainingParameters(MethodTree testMethod) {
return testMethod.getParameters().stream()
.map(VariableTree::getName)
.map(Object::toString)
.collect(joining(", ", "/* { ", " } */"));
}
private static boolean hasExpectedComment( private static boolean hasExpectedComment(
MethodTree factoryMethod, MethodTree factoryMethod,
String expectedComment, String expectedComment,