diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaFlowableToReactorTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaFlowableToReactorTemplates.java index 61dd078d..9ce0a20c 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaFlowableToReactorTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaFlowableToReactorTemplates.java @@ -681,7 +681,7 @@ final class RxJavaFlowableToReactorTemplates { @AfterTemplate Single after(Flowable flowable) { - return RxJava2Adapter.monoToSingle(RxJava2Adapter.flowableToFlux(flowable).next()); + return RxJava2Adapter.monoToSingle(RxJava2Adapter.flowableToFlux(flowable).next().single()); } } diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaSingleToReactorTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaSingleToReactorTemplates.java index b3adafbb..88ba6a26 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaSingleToReactorTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaSingleToReactorTemplates.java @@ -280,7 +280,7 @@ final class RxJavaSingleToReactorTemplates { } } - // XXX: Test this one. + // XXX: Write a test. abstract static class SingleFlatMapUnwrapLambda { @Placeholder abstract Mono placeholder(@MayOptionallyUse T input); @@ -530,7 +530,12 @@ final class RxJavaSingleToReactorTemplates { e -> RxJava2Adapter.singleToMono( Single.wrap( - RxJavaReactorMigrationUtil.toJdkFunction(function).apply(e))))); + RxJavaReactorMigrationUtil.toJdkFunction( + (Function< + ? super Throwable, + ? extends SingleSource>) + function) + .apply(e))))); } } diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaToReactorTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaToReactorTemplates.java index 87240fa0..a1aa5a63 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaToReactorTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/RxJavaToReactorTemplates.java @@ -207,17 +207,17 @@ public final class RxJavaToReactorTemplates { @SuppressWarnings("NoFunctionalReturnType") static final class UnnecessaryConsumerConversion { @BeforeTemplate - java.util.function.Consumer before(@CanTransformToTargetType Consumer consumer) { + java.util.function.Consumer before(@CanTransformToTargetType Consumer consumer) { return RxJavaReactorMigrationUtil.toJdkConsumer(consumer); } @AfterTemplate - java.util.function.Consumer after(java.util.function.Consumer consumer) { + java.util.function.Consumer after(java.util.function.Consumer consumer) { return consumer; } } - static final class UnnecessaryRunnableConversion { + static final class UnnecessaryRunnableConversion { @BeforeTemplate Runnable before(@CanTransformToTargetType Action action) { return RxJavaReactorMigrationUtil.toRunnable(action); @@ -229,16 +229,15 @@ public final class RxJavaToReactorTemplates { } } - // XXX: This one is without CanBeTransformedTo... @SuppressWarnings("NoFunctionalReturnType") static final class UnnecessaryPredicateConversion { @BeforeTemplate - java.util.function.Predicate before(Predicate predicate) { + java.util.function.Predicate before(@CanTransformToTargetType Predicate predicate) { return RxJavaReactorMigrationUtil.toJdkPredicate(predicate); } @AfterTemplate - java.util.function.Predicate after(java.util.function.Predicate predicate) { + java.util.function.Predicate after(java.util.function.Predicate predicate) { return predicate; } } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/bugpatterns/RxJavaFlowableToReactorTemplatesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/bugpatterns/RxJavaFlowableToReactorTemplatesTestOutput.java index 30ec39c0..1fbca861 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/bugpatterns/RxJavaFlowableToReactorTemplatesTestOutput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/bugpatterns/RxJavaFlowableToReactorTemplatesTestOutput.java @@ -96,7 +96,7 @@ final class RxJavaFlowableToReactorTemplatesTest implements RefasterTemplateTest } Single testFlowableFirstOrError() { - return RxJava2Adapter.monoToSingle(RxJava2Adapter.flowableToFlux(Flowable.just(1)).next()); + return RxJava2Adapter.monoToSingle(RxJava2Adapter.flowableToFlux(Flowable.just(1)).next().single()); } Completable testFlowableFlatMapCompletable() {