From 8ba4f872be95d8e331e973760c4973f559f0eac7 Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Thu, 16 May 2024 07:47:58 +0200 Subject: [PATCH] Add tests and more context in the `StringRules` file --- .../tech/picnic/errorprone/refasterrules/StringRules.java | 4 ++++ .../picnic/errorprone/refasterrules/StringRulesTestInput.java | 4 ++++ .../errorprone/refasterrules/StringRulesTestOutput.java | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StringRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StringRules.java index 3fc6d60f..bcff8ee0 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StringRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/StringRules.java @@ -246,5 +246,9 @@ final class StringRules { } // Rewrite `String#copyValueOf(char[])` to `new String(char[])`. + // Example: + // String.copyValueOf(new char[]); + // --> + // new String(new char[]); } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestInput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestInput.java index a6b2f1cb..35035d62 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestInput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestInput.java @@ -96,4 +96,8 @@ final class StringRulesTest implements RefasterRuleCollectionTestCase { int testUtf8EncodedLength() { return "foo".getBytes(UTF_8).length; } + + String testNewStringChar() { + return String.copyValueOf(new char[] {'f', 'o', 'o'}); + } } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestOutput.java index d5e1241a..fa63bae4 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestOutput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/StringRulesTestOutput.java @@ -96,4 +96,8 @@ final class StringRulesTest implements RefasterRuleCollectionTestCase { int testUtf8EncodedLength() { return Utf8.encodedLength("foo"); } + + String testNewStringChar() { + return new String(new char[] {'f', 'o', 'o'}); + } }