From 7daa39a0b52ea2245008873691d704daa1ffab9a Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Fri, 27 Dec 2024 05:30:30 +0100 Subject: [PATCH] Update comments referencing Refaster rule limitation (#46) Issue google/error-prone#2706 has been resolved; we have yet to decide how to proceed. --- .../refasterrules/ImmutableListMultimapRules.java | 3 +-- .../picnic/errorprone/refasterrules/ImmutableListRules.java | 3 +-- .../picnic/errorprone/refasterrules/ImmutableMapRules.java | 3 +-- .../errorprone/refasterrules/ImmutableMultisetRules.java | 3 +-- .../errorprone/refasterrules/ImmutableSetMultimapRules.java | 3 +-- .../picnic/errorprone/refasterrules/ImmutableSetRules.java | 3 +-- .../errorprone/refasterrules/ImmutableSortedMapRules.java | 6 ++---- 7 files changed, 8 insertions(+), 16 deletions(-) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListMultimapRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListMultimapRules.java index 3a943ab8..fc5e8b06 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListMultimapRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListMultimapRules.java @@ -36,8 +36,7 @@ final class ImmutableListMultimapRules { * Prefer {@link ImmutableListMultimap#builder()} over the associated constructor on constructions * that produce a less-specific type. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableListMultimapBuilder { @BeforeTemplate ImmutableMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java index aca741d3..80732d38 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableListRules.java @@ -28,8 +28,7 @@ final class ImmutableListRules { private ImmutableListRules() {} /** Prefer {@link ImmutableList#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableListBuilder { @BeforeTemplate ImmutableList.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMapRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMapRules.java index 8c0f9c62..fa976d33 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMapRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMapRules.java @@ -31,8 +31,7 @@ final class ImmutableMapRules { private ImmutableMapRules() {} /** Prefer {@link ImmutableMap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableMapBuilder { @BeforeTemplate ImmutableMap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMultisetRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMultisetRules.java index fee76fd8..9880ad7c 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMultisetRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableMultisetRules.java @@ -21,8 +21,7 @@ final class ImmutableMultisetRules { private ImmutableMultisetRules() {} /** Prefer {@link ImmutableMultiset#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableMultisetBuilder { @BeforeTemplate ImmutableMultiset.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetMultimapRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetMultimapRules.java index 1c704943..a07d4a09 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetMultimapRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetMultimapRules.java @@ -29,8 +29,7 @@ final class ImmutableSetMultimapRules { private ImmutableSetMultimapRules() {} /** Prefer {@link ImmutableSetMultimap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableSetMultimapBuilder { @BeforeTemplate ImmutableSetMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetRules.java index 628bb1cf..351f93d5 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSetRules.java @@ -29,8 +29,7 @@ final class ImmutableSetRules { private ImmutableSetRules() {} /** Prefer {@link ImmutableSet#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableSetBuilder { @BeforeTemplate ImmutableSet.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java index 36975c70..e2cf20ef 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableSortedMapRules.java @@ -37,8 +37,7 @@ final class ImmutableSortedMapRules { * Prefer {@link ImmutableSortedMap#naturalOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableSortedMapNaturalOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() { @@ -55,8 +54,7 @@ final class ImmutableSortedMapRules { * Prefer {@link ImmutableSortedMap#reverseOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See - // https://github.com/google/error-prone/pull/2706. + // XXX: This rule may drop generic type information, leading to non-compilable code. static final class ImmutableSortedMapReverseOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() {