4341 Commits

Author SHA1 Message Date
marschwar
481b3b2428 Fix typo in AvoidReferentialEquality rule description (#4644)
Co-authored-by: Markus Schwarz <post@markus-schwarz.net>
2022-03-19 18:08:13 +00:00
Stieglitz
14c0f11e44 Bump KtLint to 0.44.0 and add UnnecessaryParenthesesBeforeTrailingLamda rule (#4630)
* Bump KtLint to 0.44.0 and add UnnecessaryParenthesesBeforeTrailingLambda rule

* implement new RunAsLateAsPossible and RunOnRootNodeOnly annotations

* use internal ruleShouldOnlyRunOnFileNode method

* revoke line wrap

* fix indentation errors

* deprecate indentSize in ParameterListWrapping.kt

* implement microutilsKotlinLoggingJvm and fake EDITOR_CONFIG_USER_DATA_KEY

* remove duplicate
2022-03-19 12:59:56 +01:00
Dennis Pietruck
3fc2958fb0 Fix typo in CONTRIBUTING.md (#4639)
Co-authored-by: Aram Messdaghi <aram.messdaghi@otto.de>
2022-03-18 09:12:13 +01:00
davidburstrom
5325fd09a8 Fix concurrency issue when creating PomModel (#4609) (#4631)
Co-authored-by: David Burström <davidburstrom@spotify.com>
2022-03-18 09:10:40 +01:00
renovate[bot]
8bb4c85c4c Update org.spekframework.spek2 to v2.0.18 (#4627)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-12 16:36:35 +00:00
renovate[bot]
a3375f9775 Update dependency gradle to v7.4.1 (#4622)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-12 08:33:25 -08:00
Toshiaki Kameyama
7740a2a2a0 UnnecessaryAbstractClass: fix false positive when the abstract class has properties in the primary constructor (#4628)
* UnnecessaryAbstractClass: refactor

* UnnecessaryAbstractClass: fix false positive when the abstract class has properties in the primary constructor
2022-03-12 08:33:04 -08:00
Nicola Corti
ea6737f422 Properly set toolVersion on DetektExtension (#4623) 2022-03-10 11:41:36 +00:00
Toshiaki Kameyama
1269b9b5ac NamedArguments: Ignore when argument values are the same as the parameter name (#4613)
* NamedArguments: Ignore when argument values are the same as the parameter names

* Add tests
2022-03-10 11:49:30 +01:00
dependabot[bot]
3e895d6fe6 Bump github-pages from 223 to 225 in /docs (#4614)
Bumps [github-pages](https://github.com/github/pages-gem) from 223 to 225.
- [Release notes](https://github.com/github/pages-gem/releases)
- [Commits](https://github.com/github/pages-gem/compare/v223...v225)

---
updated-dependencies:
- dependency-name: github-pages
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-08 10:52:04 +01:00
renovate[bot]
f32d061733 Update actions/upload-artifact action to v3 (#4608)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-04 09:52:21 +11:00
renovate[bot]
2cc397833b Update actions/stale action to v5 (#4603)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 16:07:22 +11:00
renovate[bot]
05acb975e1 Update actions/checkout action to v3 (#4602)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:54:25 +11:00
renovate[bot]
e16439459a Update dependency io.mockk:mockk to v1.12.3 (#4599)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:54:01 +11:00
renovate[bot]
8964772b49 Update actions/download-artifact action to v3 (#4607)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-02 23:16:52 +00:00
Brais Gabín
0b5d42e7df Fix broken and outdated links (#4600) 2022-03-01 12:03:03 +00:00
Nicola Corti
9f18b6b374 Prepare Detekt 1.20.0-RC1 (#4597) v1.20.0-RC1 2022-02-28 23:04:45 +00:00
dependabot[bot]
f99cbffe7e Bump nokogiri from 1.12.5 to 1.13.3 in /docs (#4596)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.5 to 1.13.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.5...v1.13.3)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-27 08:26:12 +11:00
renovate[bot]
05d84e69ea Update actions/setup-java action to v3 (#4595)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-26 14:45:01 +11:00
renovate[bot]
7cce3816dd Update dependency com.android.tools.build:gradle to v7.1.2 (#4594)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-25 10:14:00 +11:00
Brais Gabín
dd80d61348 AnnotationSuppressor now resolves Full Qualified Annotation Names without type solving (#4570)
* Simplify AnnotationExcluderSpec

* Improve tests

* Improve tests

* Fix FullQualifiedNameGuesser

* Allow List<Regex> inside AnnotationExcluder to give more options to the callers

* Test with and without type-solving

* Make AnnotationExcluder use the BindingContext when available

* AnnotationSuppressor works with Full Qualified names without type solving

* Address PR comments

* Update detekt-psi-utils/src/test/kotlin/io/github/detekt/psi/internal/FullQualifiedNameGuesserSpec.kt

Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>

* Support star imports

* Improve readability

Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
2022-02-24 00:03:15 +01:00
Chao Zhang
6c3c28df3a Housekeep Gradle scripts (#4589)
* Housekeep Gradle scripts

* Revert changes in settings.gradle
2022-02-21 21:48:00 +11:00
Nelson Osacky
cf4b7bd091 Better error classification in Gradle Enterprise. (#4586)
* Better error classification in Gradle Enterprise.

Use `Lint failed` instead of `Build failed` in exception

Fixes #4585

* Use Analysis failed instead of Lint failed

* Fix failing test not using new artifact

* Undo change to gradle build
2022-02-19 14:51:29 -08:00
Jamie Slome
f15ce50d5e Create SECURITY.md (#4538)
* Create SECURITY.md

* Complete initial version of SECURITY.md

* Fix PR link

* Narrate our supported versions for security

* Update SECURITY.md

* Update SECURITY.md

Co-authored-by: Nicola Corti <corti.nico@gmail.com>

* Improve wording

* Update SECURITY.md

Co-authored-by: Nicola Corti <corti.nico@gmail.com>

Co-authored-by: Chao Zhang <chao.zhang@instacart.com>
Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
2022-02-15 20:58:02 -08:00
marschwar
2aad546d74 Refactor config printer to improve testability (#4580)
Co-authored-by: Markus Schwarz <post@markus-schwarz.net>
2022-02-13 22:43:01 +01:00
marschwar
b6731edbd0 Avoid usage of java stream for parameterized tests (#4579) 2022-02-10 23:51:18 +01:00
marschwar
d50224e1b0 Split rule documentation printer to improve testability (#4578)
* split rule documentation printer to improve testability

* add tests for missed code paths

Co-authored-by: Markus Schwarz <post@markus-schwarz.net>
2022-02-10 23:34:51 +01:00
Matthew Haughton
e0e4ae2986 Migrate detekt-rules-naming tests to JUnit (#4574) 2022-02-10 19:24:04 +00:00
Matthew Haughton
00a472812b Migrate detekt-gradle-plugin tests to JUnit (#4529)
* Migrate detekt-gradle-plugin functional tests to JUnit

* Migrate detekt-gradle-plugin tests to JUnit

* Remove unused dependencies

* Removed unused function
2022-02-10 18:34:33 +11:00
Matthew Haughton
7d87c80e24 Enable Gradle's configuration cache by default (#4576)
* Flag tasks known to be incompatible with Gradle's configuration cache

* Enable Gradle's configuration cache by default
2022-02-09 21:06:14 +11:00
Matthew Haughton
1b72d0082d Migrate detekt-rules-exceptions tests to JUnit (#4572)
* Migrate detekt-rules-exceptions tests to JUnit

* Improve nested test descriptions
2022-02-09 08:22:54 +11:00
Goooler
6734a9f852 Make VERSION_CATALOGS stable (#4577) 2022-02-09 08:20:32 +11:00
renovate[bot]
1cc61fce35 Update dependency gradle to v7.4 (#4573)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-08 23:11:02 +11:00
Matthew Haughton
7126e4ba3e Migrate detekt-rules-performance tests to JUnit (#4569) 2022-02-07 21:49:00 +01:00
Matthew Haughton
780849fc09 Migrate detekt-rules-complexity tests to JUnit (#4566) 2022-02-07 21:41:02 +01:00
Matthew Haughton
a2fd61dd44 Remove redundant shadowed val (#4571) 2022-02-07 13:10:24 +01:00
Matthew Haughton
56baa437ed Drop Groovy DSL testing in DetektTaskDslSpec (#4563)
* Drop Groovy DSL testing in DetektTaskDslSpec

* Reformat
2022-02-07 21:28:47 +11:00
Matt Thompson
dfd1966dfa update InvalidPackageDeclaration to report if rootPackage is not present (#4484) 2022-02-07 08:59:25 +00:00
Matthew Haughton
efcc0d95de Migrate detekt-rules-documentation tests to JUnit (#4568) 2022-02-07 09:38:36 +01:00
Matthew Haughton
04006ece92 Migrate detekt-rules-coroutines tests to JUnit (#4567) 2022-02-07 09:35:36 +01:00
Matthew Haughton
1e406db9bb Add missing task inputs (#4565)
The ANDROID_HOME and ANDROID_SDK_ROOT environment variables are accessed
by the test suite. They need to be registered as task inputs so Gradle's
up-to-date checks work correctly when the environment variable values
change.
2022-02-06 16:34:49 +11:00
Matthew Haughton
a04debc51f Remove unneeded add-opens flag (#4564)
The original issue appears fixed in recent AGP versions
2022-02-06 16:34:39 +11:00
renovate[bot]
b21f0b9538 Update dependency com.android.tools.build:gradle to v7.1.1 (#4561)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 16:22:26 +00:00
Nicola Corti
557c7d3180 Fix for missing /kotlin folder when running on Android projects (#4554) 2022-02-05 10:10:35 +00:00
Nicola Corti
56f34c4cf8 Fix AutoCorrection crashing with Missing extension point (#4545) 2022-02-04 23:11:26 +00:00
Nicola Corti
da062f9f70 Deprecate continuationIndentSize from the Indentation rule (#4551) 2022-02-04 23:11:01 +00:00
renovate[bot]
ce9d5d7323 Update plugin gradleVersions to v0.42.0 (#4559)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-04 23:06:53 +00:00
Nicola Corti
f6e2d3070e Fix broken website due to invalid baseurl (#4558) 2022-02-04 15:06:41 +01:00
Goooler
f626273153 Reuse setReportOutputConventions (#4546)
* Reuse `outputLocation.convention`

* Single line

* Rename
2022-02-04 16:38:42 +11:00
Nicola Corti
35e5dc7672 Fix broken website due to missing baseurl (#4557) 2022-02-04 16:35:39 +11:00