jlengrand/detekt
1
0
Fork 0
mirror of https://github.com/jlengrand/detekt.git synced 2026-03-10 08:11:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add UnnecessaryFilter rule (#3341)

Browse Source 
* Add tests for UnnecessaryFilter rule

* Add test for Sequence

* Implement rule: UnnecessaryFilter

* Fixed ReadMe

* fixed issues from CI

* Remove requiresTypeResolution from UnnecessaryFilter rule

* Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryFilter.kt

Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>

* Fixe false-positives case with filter function, fixed spelling and add test to rule error message

* Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryFilter.kt

Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>

* add check operator by Fq name

* fixed linter issue

* Update detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryFilter.kt

Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>

* Update detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryFilterSpec.kt

Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>

Co-authored-by: Chao Zhang <zhangchao6865@gmail.com>
Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
This commit is contained in:
Volodymyr
2021-01-29 23:45:25 +02:00
committed by GitHub
parent 9327ebed7a
commit a26038388f
5 changed files with 262 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -213,7 +213,7 @@ If you contributed to detekt but your name is not in the list, please feel free
- [Remco Mokveld](https://github.com/remcomokveld) - Rename Blacklist/Whitelist to more meaningful names
- [Zachary Moore](https://github.com/zsmoore) - Rule, cli, gradle plugin, and config improvements
- [Veyndan Stuart](https://github.com/veyndan) - New rule: UseEmptyCounterpart; Rule improvement: UselessCallOnNotNull
- [Parimatch Tech](https://github.com/parimatchtech) - New rule: LibraryEntitiesShouldNotBePublic
- [Parimatch Tech](https://github.com/parimatch-tech) - New rule: LibraryEntitiesShouldNotBePublic, UnnecessaryFilter
- [Chao Zhang](https://github.com/chao2zhang) - SARIF report format; Rule improvements
- [Marcelo Hernandez](https://github.com/mhernand40) - New rule: SuspendFunWithFlowReturnType
- [Harold Martin](https://github.com/hbmartin) - Rule improvement: ClassOrdering