From 05546164893fae2a6dec9268c2a0ca729ec6aad2 Mon Sep 17 00:00:00 2001 From: "dima.avdeev" <99798741+dima-avdeev-jb@users.noreply.github.com> Date: Mon, 17 Oct 2022 21:46:42 +0300 Subject: [PATCH] uikit open simulator, simplify availability condition (#2414) --- .../compose/experimental/uikit/internal/SimctlListData.kt | 6 +++++- .../experimental/uikit/internal/registerSimulatorTasks.kt | 4 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/SimctlListData.kt b/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/SimctlListData.kt index 2a765e19..90d68114 100644 --- a/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/SimctlListData.kt +++ b/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/SimctlListData.kt @@ -55,7 +55,11 @@ internal class DeviceData( val dataPathSize: Long? = null, val logPath: String? = null, val udid: String, - val isAvailable: Boolean? = null, + /** + * Simulator may be unavailable after update Xcode version. + * By default, we think what simulator is available. + */ + val isAvailable: Boolean = true, val deviceTypeIdentifier: String? = null, val state: String, ) diff --git a/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/registerSimulatorTasks.kt b/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/registerSimulatorTasks.kt index 148d01ff..eee6cb41 100644 --- a/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/registerSimulatorTasks.kt +++ b/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/uikit/internal/registerSimulatorTasks.kt @@ -36,9 +36,7 @@ fun Project.registerSimulatorTasks( doLast { val device = getSimctlListData().devices.map { it.value }.flatten() .firstOrNull { device: DeviceData -> - val xcode13Condition = device.state.contains("unavailable") - val xcode14Condition = device.isAvailable == false - device.name == deviceName && (xcode13Condition || xcode14Condition) + device.name == deviceName && !device.isAvailable } if (device != null) { runExternalTool(