An event always has a single (automatically calculated) Grouping associated with it.
We add this info to the Event model (we'll soon display it in the UI, and as per the
now-removed comment it's simply the consistent thing to do)
Mysteriously, "Truncated incorrect DOUBLE value". But we have no Double fields.
Answer: adding a value to a field (with "+") tries to convert to Double first
on MySQL. Using Concat solves it.
Showed up in all paths exept "resolved by next".
Fix#14
prompted by the LHS going awry, esp. the part where the 'Show all' etc buttons
git commit -m "'Issue Key Info'; show on xl, not lg. (while recording a video
at 1080px width)
in the lists; this is easier to read than a strikethrough.
I experimented with text-decoration-style and text-decoration-style but that
didn't make it better.
Our big brother doesn't bother to reveal the resolvedness of issues in lists
_at all_, btw. Surprising!
Multiple problems w/ <a name
* in itself deprecated
* my approach of self-closing <a is illegal too
replaced w/ spans where necessary.
Further notes:
'topp' was never used; '#top' is taken too, so I went with first-frame (stil unused, 'maybe later')
The fixes in this and preceding commits were inspired by running "Nu Html Checker"
docker run -it --rm -p 8888:8888 ghcr.io/validator/validator:latest
files were simply saved in Firefox and then uploaded; make sure to ignore the warning which is caused by Firefox:
> A document must not include both a meta element with an http-equiv attribute whose value is content-type, and a meta element with a charset attribute.
I limited checking to the issue-list and various event-detail pages.
* As per the spec 'takes precendence'
* Also fixes the reported bug on Laravel, which apparently doesn't send event_id
as part of the event payload.
* Fixes the envelope tests (they were doing nothing when I moved the
data samples around recently)
* Adds a 'no event_id in data, but yes in envelope' test to that test.
* Adds handling to send_json such that we can send envelopes when the event_id
is missing from the event data.
This reverts course on 4201fbd778, and restores event.schema.json from that
commit. In that commit we said: 'this is not used'. Not true: it's used in a
test, though this test used the validity check to silently skip.
In this commit:
1. Do _not_ just silently skip invalid samples. Since we have a way of properly
validating, let's use that so that we know how useful the samples that we have
actually are.
2. Deal with "_meta", a field that we sometimes see in the "private samples" (data
that ultimately comes from running a somewhat recent python-sdk against my
actual codebase). The need for this was exposed by [1]
3. Add a test for the up-to-date-ness of event.json.schema
4. remove special-cased attribute-checks in `is_valid`; `send_json` was, at the
time, an opportunistic way to just get my hands on some sample data. the
approach at validation reflected that: I just did some tests on the existence
of certain attributes to determine which json files were even events. But in
the end I did a full validation using an API schema, which kinda made the
whole business useless. This commit cleans up the individual checks.
