jlengrand/bugsink
1
0
Fork 0
mirror of https://github.com/jlengrand/bugsink.git synced 2026-03-10 08:01:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

When selecting text in the stacktrace frameHeader, don't toggle the frame

Browse Source 
The frameheader is a typical target for copy/paste actions (filenames/paths)
and having stuff jump around right after selecting is annoying
This commit is contained in:
Klaas van Schelven
2025-08-29 09:34:14 +02:00
parent 6a523a6a67
commit d62d016be3
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
static/js/issue_stacktrace.js
View File

@@ -88,6 +88,17 @@ function expandSection(element) {
} }
function toggleFrameVisibility(frameHeader) { function toggleFrameVisibility(frameHeader) {
console.log("toggling frame visibility");
const selection = window.getSelection().toString();
if (selection.length > 0) {
// don't toggle if the user is selecting text (which one might do to copy a
// filename or similar); the assumption here is: if there's a selection,
// it was just created using the mouse because non-selecting mouseclick
// deselect all text before the click is triggered. this assumption
// holds on desktop browsers; on mobile we might need to refine this.
return;
}
const frameDetails = frameHeader.parentNode.querySelector(".js-frame-details"); const frameDetails = frameHeader.parentNode.querySelector(".js-frame-details");
if (frameDetails.getAttribute("data-collapsed") === "true") { if (frameDetails.getAttribute("data-collapsed") === "true") {
expandSection(frameDetails); expandSection(frameDetails);