From 7f2e4b786b31db7b007e6a45d8c37ba0c2bc0bb5 Mon Sep 17 00:00:00 2001 From: Klaas van Schelven Date: Sun, 18 May 2025 09:15:43 +0200 Subject: [PATCH] Default worker-count in Docker: 1 instead of 10 My reasoning is twofold: 1. a count of 1 is actually probably "enough for many setups" because ingestion is very fast anyway (just store the file); while the lower memory-footprint that comes with having fewer workers means that adoption of Bugsink will be easier. 2. tuning the variable is going to be less annoying if there's no default that might override "in the wrong direction" (i.e. the interaction between `WEB_CONCURRENCY` and `GUNICORN_CMD_ARGS`) See #101 (where the concept of customizability was discussed, though not the present idea of chaning the default). --- CHANGELOG.md | 12 ++++++++++++ Dockerfile | 1 - Dockerfile.fromwheel | 1 - 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ac30e50..6015b0b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,17 @@ # Changes +## x.x.x (xx xxx xxxx) + +### Backwards-incompatible changes + +* The default number of web processes (gunicorn server workers) in the + dockerized setup is now 1 (it used to be 10). + + set `WEB_CONCURRENCY=...` or `GUNICORN_CMD_ARGS="--workers=..."` to + restore the previous behavior or choose a custom number. + +### ... + ## 1.5.4 (12 May 2025) * Add bugsink-util script to allow settings-independent commands to be run diff --git a/Dockerfile b/Dockerfile index b3f61ab..6ddef91 100644 --- a/Dockerfile +++ b/Dockerfile @@ -22,7 +22,6 @@ FROM python:${PYTHON_VERSION}-slim ENV PYTHONUNBUFFERED=1 ENV PORT=8000 -ENV GUNICORN_CMD_ARGS="--workers=10" WORKDIR /app diff --git a/Dockerfile.fromwheel b/Dockerfile.fromwheel index 29bfb89..fca9924 100644 --- a/Dockerfile.fromwheel +++ b/Dockerfile.fromwheel @@ -51,7 +51,6 @@ ARG WHEEL_FILE=wheelfile-not-specified.whoops ENV PYTHONUNBUFFERED=1 ENV PORT=8000 -ENV GUNICORN_CMD_ARGS="--workers=10" WORKDIR /app