From 33d5865579975499523aa58270b4c79ce068993f Mon Sep 17 00:00:00 2001 From: Klaas van Schelven Date: Tue, 3 Jun 2025 15:47:46 +0200 Subject: [PATCH] Clarifying comments on logmessage display --- issues/views.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/issues/views.py b/issues/views.py index 1e7af68..40ebfa8 100644 --- a/issues/views.py +++ b/issues/views.py @@ -612,6 +612,8 @@ def issue_event_details(request, issue, event_pk=None, digest_order=None, nav=No logentry_key = "logentry" if "logentry" in parsed_data else "message" if isinstance(parsed_data.get(logentry_key), dict): + # NOTE: event.schema.json says "If `message` and `params` are given, Sentry will attempt to backfill + # `formatted` if empty." but we don't do that yet. if parsed_data.get(logentry_key, {}).get("formatted"): logentry_info.append(("formatted", parsed_data[logentry_key]["formatted"])) @@ -626,7 +628,7 @@ def issue_event_details(request, issue, event_pk=None, digest_order=None, nav=No for param_k, param_v in params.items(): logentry_info.append((param_k, param_v)) - elif isinstance(parsed_data.get(logentry_key), str): + elif isinstance(parsed_data.get(logentry_key), str): # robust for top-level as str (see #55) logentry_info.append(("message", parsed_data[logentry_key])) key_info += [