From 228ef184e1be5895d7a92a564ae1b86a6d34edc4 Mon Sep 17 00:00:00 2001 From: Klaas van Schelven Date: Thu, 20 Jun 2024 09:21:55 +0200 Subject: [PATCH] refactoring: class-definition order should not matter but keeping the fields together is better --- projects/models.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/projects/models.py b/projects/models.py index f42ef6b..058a55e 100644 --- a/projects/models.py +++ b/projects/models.py @@ -52,6 +52,14 @@ class Project(models.Model): # denormalized/cached fields below has_releases = models.BooleanField(editable=False, default=False) + # alerting conditions + alert_on_new_issue = models.BooleanField(default=True) + alert_on_regression = models.BooleanField(default=True) + alert_on_unmute = models.BooleanField(default=True) + + # visibility + visibility = models.IntegerField(choices=ProjectVisibility.choices, default=ProjectVisibility.TEAM_MEMBERS) + def __str__(self): return self.name @@ -68,15 +76,6 @@ class Project(models.Model): models.Index(fields=["id", "sentry_key"]), ] """ - - # alerting conditions - alert_on_new_issue = models.BooleanField(default=True) - alert_on_regression = models.BooleanField(default=True) - alert_on_unmute = models.BooleanField(default=True) - - # visibility - visibility = models.IntegerField(choices=ProjectVisibility.choices, default=ProjectVisibility.TEAM_MEMBERS) - def get_latest_release(self): # TODO perfomance considerations... this can be denormalized/cached at the project level from releases.models import ordered_releases