From c65a85eeb8c65e6efc537f12c63aecf7f270f98a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20de=20Arriba?= Date: Mon, 31 Jul 2017 12:46:17 +0200 Subject: [PATCH 1/3] Update testing --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 8a9d5b7..2965cfd 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,8 @@ before_install: - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install freetype bison27 gettext icu4c jpeg libpng openssl readline homebrew/dupes/zlib curl; fi - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force bison27; fi +- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force icu4c; fi +- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export PHP_CONFIGURE_OPTIONS='--disable-gettext' fi - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get update -qq; fi - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install curl build-essential autoconf libjpeg-dev libpng12-dev openssl libssl-dev libcurl4-openssl-dev pkg-config From c78382e6be9d9639919ad2ee153ba45da74a00c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20de=20Arriba?= Date: Mon, 31 Jul 2017 12:51:09 +0200 Subject: [PATCH 2/3] Update README --- README.md | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 969dd02..390f209 100644 --- a/README.md +++ b/README.md @@ -16,6 +16,8 @@ PHP plugin for [asdf version manager](https://github.com/HashNuke/asdf). asdf plugin-add php https://github.com/odarriba/asdf-php.git ``` +**Please, remember installing the common required libraries that can be found on the `asdf` README. They are necessary to build PHP versions too!** + ### Linux You may need this libraries and packages to be able to compile PHP compiler versions: @@ -32,12 +34,22 @@ In order to compile PHP on macOS machines, you must install some brew packages f brew install freetype bison@2.7 gettext icu4c jpeg libpng openssl readline homebrew/dupes/zlib ``` -and, in order to compile 5.x versions of PHP, you **must** link `bison27` package: +and, in order to compile 5.x versions of PHP, you **must** link `bison27` and `icu4c` packages: ``` -brew link --force bison@2.7 +$ brew link --force bison@2.7 +$ brew link --force icu4c ``` +**Important note**: There seems to be a bug with PHP `configure` file on recent versions (> 7.1.4) when using on OSX environments. As can be seen in [this PR](https://github.com/phpbrew/phpbrew/issues/876#issuecomment-301553990), it's needed to disable gettext at build time to work, and later on impate the module manually. + +To disable it, just execute this **before** run the `asdf install` command: + +``` +$ export PHP_CONFIGURE_OPTIONS='--disable-gettext' +``` + + ## Development To modify this plugin into your `asdf` installation and see changes live, just create a symlink: From 6fd1b50d352cf4185317d342766f1cc578176ba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=93scar=20de=20Arriba?= Date: Mon, 31 Jul 2017 12:54:18 +0200 Subject: [PATCH 3/3] Update travis config --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2965cfd..1fcf82e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,7 @@ before_install: icu4c jpeg libpng openssl readline homebrew/dupes/zlib curl; fi - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force bison27; fi - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force icu4c; fi -- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export PHP_CONFIGURE_OPTIONS='--disable-gettext' fi +- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export PHP_CONFIGURE_OPTIONS='--disable-gettext'; fi - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get update -qq; fi - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install curl build-essential autoconf libjpeg-dev libpng12-dev openssl libssl-dev libcurl4-openssl-dev pkg-config