From d982bc94cb5d539c8950285f95f97cee886db3ed Mon Sep 17 00:00:00 2001 From: julien Lengrand-Lambert Date: Sat, 25 Oct 2025 23:43:04 +0100 Subject: [PATCH] Adding retro Java 17 compatibility * Moving back to Java 17 compatibility. I'll change demo-remote a little later, because otherwise I have to break the project for some time. * Prepares version 0.1.3 --- .idea/misc.xml | 2 +- CLAUDE.md | 3 ++- CONTRIBUTING.md | 2 +- demo/build.gradle.kts | 2 +- opengraphkt/build.gradle.kts | 12 ++++++++++-- scrape-test/build.gradle.kts | 2 +- 6 files changed, 16 insertions(+), 7 deletions(-) diff --git a/.idea/misc.xml b/.idea/misc.xml index 756b302..498ffa5 100644 --- a/.idea/misc.xml +++ b/.idea/misc.xml @@ -4,7 +4,7 @@ - + \ No newline at end of file diff --git a/CLAUDE.md b/CLAUDE.md index f1863f1..13eaa15 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -66,7 +66,8 @@ The parser extracts `meta[property^=og:]` tags and builds structured data models ## Development Notes -- **JVM Toolchain**: Java 24 (see `jvmToolchain(24)` in build files) +- **JVM Toolchain**: Java 17 (see `jvmToolchain(17)` in build files) +- **Minimum Java Version**: Java 17 (required by Ksoup dependency) - **Testing**: CI matrix tests on Java 17 and 23 via GitHub Actions - **Dependencies**: Core library uses Ksoup (v0.2.5) for HTML parsing and network requests - **Maven Coordinates**: Group `fr.lengrand`, artifact `opengraphkt`, currently at `0.1.2-SNAPSHOT` diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b872f9..24e58fd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ Thank you for your interest in contributing to OpenGraphKt! This document provid ### Prerequisites -- Java 24 (JVM toolchain) +- Java 17 or later (JVM toolchain configured for Java 17) - Gradle 8.14.3+ (wrapper included) - Git diff --git a/demo/build.gradle.kts b/demo/build.gradle.kts index 9030d4b..e0c1c90 100644 --- a/demo/build.gradle.kts +++ b/demo/build.gradle.kts @@ -24,7 +24,7 @@ tasks.test { } kotlin { - jvmToolchain(24) + jvmToolchain(17) } application { diff --git a/opengraphkt/build.gradle.kts b/opengraphkt/build.gradle.kts index cf8bf68..c75328b 100644 --- a/opengraphkt/build.gradle.kts +++ b/opengraphkt/build.gradle.kts @@ -5,7 +5,7 @@ plugins { } group = "fr.lengrand" -version = "0.1.3-SNAPSHOT" +version = "0.1.3" repositories { mavenCentral() @@ -33,8 +33,16 @@ tasks.jar { } } +java { + sourceCompatibility = JavaVersion.VERSION_17 + targetCompatibility = JavaVersion.VERSION_17 +} + kotlin { - jvmToolchain(24) + jvmToolchain(17) + compilerOptions { + jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17) + } } mavenPublishing { diff --git a/scrape-test/build.gradle.kts b/scrape-test/build.gradle.kts index bf5d03e..8d5e2cc 100644 --- a/scrape-test/build.gradle.kts +++ b/scrape-test/build.gradle.kts @@ -24,5 +24,5 @@ tasks.test { useJUnitPlatform() } kotlin { - jvmToolchain(24) + jvmToolchain(17) } \ No newline at end of file