jlengrand/Maestro
1
0
Fork 0
mirror of https://github.com/jlengrand/Maestro.git synced 2026-03-10 08:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix stats-db backup tests and harden regex escaping

Browse Source 
Test fixes: removed shadowed mockFsReaddirSync variable, moved
vi.resetModules() to beforeEach, added pragma integrity_check mock,
and fixed existsSync mock for daily backup creation test.

Production hardening: escape baseName dots in regex patterns used by
getAvailableBackups() and rotateOldBackups() to prevent unintended
matches when db filename contains regex metacharacters.
This commit is contained in:
Pedram Amini
2026-02-05 18:02:14 -06:00
parent ec7abca6dd
commit 33355253eb
2 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/__tests__/main/stats/stats-db.test.ts
View File

@@ -683,31 +683,21 @@ describe('Database file creation on first launch', () => {
* Daily backup system tests
*/
describe('Daily backup system', () => {
const mockFsReaddirSync = vi.fn();
beforeEach(() => {
vi.resetModules();
vi.clearAllMocks();
lastDbPath = null;
mockDb.pragma.mockReturnValue([{ user_version: 3 }]);
// Return integrity_check: 'ok' so initialize() doesn't trigger corruption recovery
mockDb.pragma.mockImplementation((pragmaStr: string) => {
if (pragmaStr === 'integrity_check') return [{ integrity_check: 'ok' }];
return [{ user_version: 3 }];
});
mockDb.prepare.mockReturnValue(mockStatement);
mockStatement.run.mockReturnValue({ changes: 1 });
mockStatement.get.mockReturnValue({ value: '0' }); // Old vacuum timestamp
mockStatement.all.mockReturnValue([]);
mockFsExistsSync.mockReturnValue(true);
mockFsReaddirSync.mockReturnValue([]);
// Mock readdirSync in the fs mock
vi.doMock('fs', () => ({
existsSync: (...args: unknown[]) => mockFsExistsSync(...args),
mkdirSync: (...args: unknown[]) => mockFsMkdirSync(...args),
copyFileSync: (...args: unknown[]) => mockFsCopyFileSync(...args),
unlinkSync: (...args: unknown[]) => mockFsUnlinkSync(...args),
renameSync: (...args: unknown[]) => mockFsRenameSync(...args),
statSync: (...args: unknown[]) => mockFsStatSync(...args),
readFileSync: (...args: unknown[]) => mockFsReadFileSync(...args),
writeFileSync: (...args: unknown[]) => mockFsWriteFileSync(...args),
readdirSync: (...args: unknown[]) => mockFsReaddirSync(...args),
}));
});
afterEach(() => {
@@ -828,6 +818,13 @@ describe('Daily backup system', () => {
describe('daily backup creation on initialize', () => {
it('should attempt to create daily backup on initialization', async () => {
const today = new Date().toISOString().split('T')[0];
// existsSync returns false for today's daily backup so createDailyBackupIfNeeded proceeds
mockFsExistsSync.mockImplementation((p: unknown) => {
if (typeof p === 'string' && p.includes(`daily.${today}`)) return false;
return true;
});
const { StatsDB } = await import('../../../main/stats');
const db = new StatsDB();
db.initialize();

4
src/main/stats/stats-db.ts
View File

@@ -384,7 +384,7 @@ export class StatsDB {
private rotateOldBackups(keepDays: number): void {
try {
const dir = path.dirname(this.dbPath);
const baseName = path.basename(this.dbPath);
const baseName = path.basename(this.dbPath).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const files = fs.readdirSync(dir);
const cutoffDate = new Date();
@@ -420,7 +420,7 @@ export class StatsDB {
getAvailableBackups(): Array<{ path: string; date: string; size: number }> {
try {
const dir = path.dirname(this.dbPath);
const baseName = path.basename(this.dbPath);
const baseName = path.basename(this.dbPath).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const files = fs.readdirSync(dir);
const backups: Array<{ path: string; date: string; size: number }> = [];