mirror of
https://github.com/jlengrand/Maestro.git
synced 2026-03-10 08:31:19 +00:00
Developer Experience Improvements (multi-worktree simultaneous development) (#209)
* docs: add git hash display and configurable dev server port ## CHANGES - Add `VITE_PORT` env variable to configure dev server port - Display git commit hash in About modal next to version - Add `__GIT_HASH__` build-time constant to both Vite configs - Document running multiple Maestro instances with git worktrees - Update CONTRIBUTING.md with parallel development instructions * feat: add configurable ports for dev servers - Allow VITE_PORT to configure main dev server port - Update main window to load from configurable port - Enable VITE_WEB_PORT for web interface dev server - Add note in CONTRIBUTING.md about port configuration - Log port usage in development mode * docs: update CONTRIBUTING.md section and fix React DevTools script initialization ## CHANGES - Rename "Linting" section to "Linting & Pre-commit Hooks" in table of contents - Move script variable declaration outside conditional block - Fix React DevTools script initialization order in index.html * chore: update `.vscode/settings.json` with new markdownlint config * fix: disable biome linting. Project uses ESLint * chore: Update baseline-browser-mapping (>2 months old, warning message on "npm run build:web") * chore: add .vscode/ to gitignore * chore: fix gitignore to ignore .cscode/* files properly * fix * chore: stop tracking .vscode/ files, respect gitignore Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -11,48 +11,49 @@ const appVersion = process.env.VITE_APP_VERSION || packageJson.version;
|
||||
|
||||
// Get the first 8 chars of git commit hash for dev mode
|
||||
function getCommitHash(): string {
|
||||
try {
|
||||
// Note: execSync is safe here - no user input, static git command
|
||||
return execSync('git rev-parse HEAD', { encoding: 'utf-8' }).trim().slice(0, 8);
|
||||
} catch {
|
||||
return '';
|
||||
}
|
||||
try {
|
||||
// Note: execSync is safe here - no user input, static git command
|
||||
return execSync('git rev-parse HEAD', { encoding: 'utf-8' }).trim().slice(0, 8);
|
||||
} catch {
|
||||
return '';
|
||||
}
|
||||
}
|
||||
|
||||
const disableHmr = process.env.DISABLE_HMR === '1';
|
||||
|
||||
export default defineConfig(({ mode }) => ({
|
||||
plugins: [react({ fastRefresh: !disableHmr })],
|
||||
root: path.join(__dirname, 'src/renderer'),
|
||||
base: './',
|
||||
define: {
|
||||
__APP_VERSION__: JSON.stringify(appVersion),
|
||||
// Show commit hash only in development mode
|
||||
__COMMIT_HASH__: JSON.stringify(mode === 'development' ? getCommitHash() : ''),
|
||||
// Explicitly define NODE_ENV for React and related packages
|
||||
'process.env.NODE_ENV': JSON.stringify(mode),
|
||||
},
|
||||
resolve: {
|
||||
alias: {
|
||||
// In development, use wdyr.dev.ts which loads why-did-you-render
|
||||
// In production, use wdyr.ts which is empty (prevents bundling the library)
|
||||
'./wdyr': mode === 'development'
|
||||
? path.join(__dirname, 'src/renderer/wdyr.dev.ts')
|
||||
: path.join(__dirname, 'src/renderer/wdyr.ts'),
|
||||
},
|
||||
},
|
||||
esbuild: {
|
||||
// Strip console.* and debugger in production builds
|
||||
drop: mode === 'production' ? ['console', 'debugger'] : [],
|
||||
},
|
||||
build: {
|
||||
outDir: path.join(__dirname, 'dist/renderer'),
|
||||
emptyOutDir: true,
|
||||
},
|
||||
server: {
|
||||
port: 5173,
|
||||
hmr: !disableHmr,
|
||||
// Disable file watching entirely when HMR is disabled to prevent any reloads
|
||||
watch: disableHmr ? null : undefined,
|
||||
},
|
||||
plugins: [react({ fastRefresh: !disableHmr })],
|
||||
root: path.join(__dirname, 'src/renderer'),
|
||||
base: './',
|
||||
define: {
|
||||
__APP_VERSION__: JSON.stringify(appVersion),
|
||||
// Show commit hash only in development mode
|
||||
__COMMIT_HASH__: JSON.stringify(mode === 'development' ? getCommitHash() : ''),
|
||||
// Explicitly define NODE_ENV for React and related packages
|
||||
'process.env.NODE_ENV': JSON.stringify(mode),
|
||||
},
|
||||
resolve: {
|
||||
alias: {
|
||||
// In development, use wdyr.dev.ts which loads why-did-you-render
|
||||
// In production, use wdyr.ts which is empty (prevents bundling the library)
|
||||
'./wdyr':
|
||||
mode === 'development'
|
||||
? path.join(__dirname, 'src/renderer/wdyr.dev.ts')
|
||||
: path.join(__dirname, 'src/renderer/wdyr.ts'),
|
||||
},
|
||||
},
|
||||
esbuild: {
|
||||
// Strip console.* and debugger in production builds
|
||||
drop: mode === 'production' ? ['console', 'debugger'] : [],
|
||||
},
|
||||
build: {
|
||||
outDir: path.join(__dirname, 'dist/renderer'),
|
||||
emptyOutDir: true,
|
||||
},
|
||||
server: {
|
||||
port: process.env.VITE_PORT ? parseInt(process.env.VITE_PORT) : 5173,
|
||||
hmr: !disableHmr,
|
||||
// Disable file watching entirely when HMR is disabled to prevent any reloads
|
||||
watch: disableHmr ? null : undefined,
|
||||
},
|
||||
}));
|
||||
|
||||
Reference in New Issue
Block a user